-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fp8 Quantization Support #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgoin
reviewed
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work!
bfineran
previously approved these changes
May 28, 2024
dbogunowicz
previously approved these changes
Jun 12, 2024
bfineran
previously approved these changes
Jun 17, 2024
dbogunowicz
previously approved these changes
Jun 18, 2024
bfineran
approved these changes
Jun 19, 2024
dbogunowicz
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new fp8 quantization format. For now fp8 is assumed to be torch.float8_e4m3fn, in the future we could expand to support torch.float8_e5m2 as well by expanding
QuantizationArgs
.The main change here is adding some additional checks to deal with float vs int quantization, as the range and rounding is calculated differently. Since the logic for fp8 compression is the same as int8 aside from a difference in the cast, I merged them into a single compressor. However the int8 compressor can still be referenced by its original "int-quantized" name so this won't break anything on the sparseml or vllm side
Testing
Added additional unit tests to test compression/decompression and scale/zp calculations.
Example/Evaluation
Requires sparseml FP8 PR to run: neuralmagic/sparseml#2306
Evaluated with
sparseml.evaluate /network/sadkins/llama1.1b_fp8_gptq -d wikitext -i lm-evaluation-harness
. Perplexity looks good at 14.53, it was 14.43 for the dense input model