Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some blatantly wrong IPFS CIDs aren't immediately purged from the worker #33

Closed
TimDaub opened this issue Jul 4, 2022 · 1 comment
Closed

some blatantly wrong IPFS CIDs aren't immediately purged from the worker #33

TimDaub opened this issue Jul 4, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@TimDaub
Copy link
Collaborator

TimDaub commented Jul 4, 2022

e.g. here this CID uses a minus char in its name: "https://github.com/neume-network/data/runs/7186772889?check_suite_focus=true#step:7:55731"

We should integrate an IPFS CID validator before making requests
@TimDaub TimDaub added the bug Something isn't working label Jul 4, 2022
@TimDaub
Copy link
Collaborator Author

TimDaub commented Sep 6, 2022

see:

il3ven added a commit that referenced this issue Sep 26, 2022
@il3ven
validate CID before making a request
0949f14 
This commit also removes @neume-network/message-schema because it has
been deprecated.

Fixes #33
@TimDaub TimDaub mentioned this issue Sep 30, 2022
Merged
@TimDaub TimDaub closed this as completed in 57f641e Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TimDaub