adding juniper_junos_show_system_processes_summary.textfsm support

[jnicholson56]

Adding support for Juniper Junos show system processes summary command.

[mjbear]

@jnicholson56
You're probably getting back from a winter break. 😀
Heads up that there are a few suggestions on this junos show system processes summary template that are pending your review.

Thank you!

[jnicholson56]

Thanks for the reminder. I keep telling myself I am going to work on this but keep not doing it. 😀 I will make an attempt to get it done. The suggestions are pretty straightforward from what I remember and should be easy to complete.

…

On Fri, Jan 3, 2025, 14:01 Michael Bear ***@***.***> wrote: @jnicholson56 <https://github.com/jnicholson56> You're probably getting back from a winter break. 😀 Heads up that there are a few suggestions on this junos show system processes summary template that are pending your review. Thank you! — Reply to this email directly, view it on GitHub <#1921 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AILVUEWSL6C2TZRHPPN5XA32I3UA3AVCNFSM6AAAAABS4OJCOWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRZG42DQNBQGQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[jnicholson56]

I updated the files based on the requested changes

[mjbear]

I updated the files based on the requested changes

Thank you.
I'm going to focus on PR #1922 since it seems to be an overall simpler template.
We can swing back around to this one once that one is ready to go.

[jnicholson56]

That works for me. I have a lot of templates to add eventually and doing them one at a time is probably for the best. I suspect they are all going to need work before they are accepted ☺️

…

On Sat, Jan 4, 2025, 14:22 Michael Bear ***@***.***> wrote: I updated the files based on the requested changes Thank you. I'm going to focus on PR #1922 <#1922> since it seems to be an overall simpler template. We can swing back around to this one once that one is ready to go. — Reply to this email directly, view it on GitHub <#1921 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AILVUER52DWHQ3U4ZXWEV6D2JA7IZAVCNFSM6AAAAABS4OJCOWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZRGQYDENJTHA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[mjbear]

That works for me. I have a lot of templates to add eventually and doing them one at a time is probably for the best. I suspect they are all going to need work before they are accepted ☺️

There was a learning curve for me too where the group was asking me to change regexes.

You'll figure out the common suggestions and be able to proactively tweak templates. 😉

[mjbear]

Update: Disregard. Jacob created #1965

@jnicholson56
We need to add an entry for this new template to the index file. Please include that in this PR.

The below is the test system telling us it doesn't know about this template (because the index doesn't say the template exists).

E           ntc_templates.parse.ParsingException: Unable to parse command "show system processes summary"
on platform juniper_junos - No template found for attributes:
"{'Command': 'show system processes summary', 'Platform': 'juniper_junos'}"

ntc_templates/parse.py:82: ParsingException

[jmcgill298]

thanks @jnicholson56 I forked this and updated the index file in order to get this across the finish line and clean up some of the backlog

[jnicholson56]

That is unfortunate. The other PR had an active question that I needed an answer too so I could finish the both properly. I will open my question as an issue and resubmit them again later once I figure out the proper direction for them.

…

On Tue, Jan 7, 2025, 12:32 Jacob McGill ***@***.***> wrote: thanks @jnicholson56 <https://github.com/jnicholson56> I forked this and updated the index file in order to get this across the finish line and clean up some of the backlog — Reply to this email directly, view it on GitHub <#1921 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AILVUESLNHLVMRGANRHDNDD2JQMTVAVCNFSM6AAAAABS4OJCOWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZVHE3TGMRUGE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[mjbear]

That is unfortunate. The other PR had an active question that I needed an answer too so I could finish the both properly. I will open my question as an issue and resubmit them again later once I figure out the proper direction for them.

@jnicholson56
I've learned a bit about GitHub over time and the more I know the smoother it goes.
When you're opening PRs, they can be set as a Draft (I suggest doing that out of the gate if the PR isn't quite ready) and when it's ready to go then mark it as Ready for review.

We can link the new PR to the old one, no issue there. 🙂

GitHub docs example "You can mark a draft pull request as ready for review or convert a pull request to a draft."