Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a wrapper for vpp connections with extended timeout #9

Merged
merged 6 commits into from
Nov 28, 2024
Merged

Add a wrapper for vpp connections with extended timeout #9

merged 6 commits into from
Nov 28, 2024

Conversation

NikitaSkrynnik
Copy link

Description

Add a wrapper for vpp connections that uses extended timeout for all vpp operations

Issue

networkservicemesh/cmd-forwarder-vpp#1133

@NikitaSkrynnik
add a wrapper for vpp connections with extended timeout
892202b 
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
@NikitaSkrynnik
change package name
9879d70 
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
@NikitaSkrynnik
apply review comments
c667f25 
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
denis-tingaikin
denis-tingaikin reviewed Nov 27, 2024
View reviewed changes
Copy link
Member

@denis-tingaikin denis-tingaikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added one major comment. Other things looks good. Would be nice to test it on our CI ;)

go.mod Outdated Show resolved Hide resolved
@NikitaSkrynnik
get rid of sdk dependency
3c189d6 
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
@NikitaSkrynnik
add unit tests for extended connection
8181032 
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
@NikitaSkrynnik
add more unit tests
eaa83e4 
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
@denis-tingaikin denis-tingaikin merged commit f488145 into networkservicemesh:main Nov 28, 2024
8 checks passed
nsmbot pushed a commit to networkservicemesh/cmd-nsc-vpp that referenced this pull request Nov 28, 2024
Update go.mod and go.sum to latest version from networkservicemesh/vp…
19b063a 
…phelper@main

PR link: networkservicemesh/vpphelper#9

Commit: f488145
Author: Denis Tingaikin
Date: 2024-11-28 05:43:52 -0500
Message:
  - Merge pull request #9 from NikitaSkrynnik/extended
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-simple-vl3-docker that referenced this pull request Nov 28, 2024
Update go.mod and go.sum to latest version from networkservicemesh/vp…
44ce80d 
…phelper@main

PR link: networkservicemesh/vpphelper#9

Commit: f488145
Author: Denis Tingaikin
Date: 2024-11-28 05:43:52 -0500
Message:
  - Merge pull request #9 from NikitaSkrynnik/extended
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-icmp-responder-vpp that referenced this pull request Nov 28, 2024
Update go.mod and go.sum to latest version from networkservicemesh/vp…
4d48742 
…phelper@main

PR link: networkservicemesh/vpphelper#9

Commit: f488145
Author: Denis Tingaikin
Date: 2024-11-28 05:43:52 -0500
Message:
  - Merge pull request #9 from NikitaSkrynnik/extended
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-forwarder-vpp that referenced this pull request Nov 28, 2024
Update go.mod and go.sum to latest version from networkservicemesh/vp…
3f80183 
…phelper@main

PR link: networkservicemesh/vpphelper#9

Commit: f488145
Author: Denis Tingaikin
Date: 2024-11-28 05:43:52 -0500
Message:
  - Merge pull request #9 from NikitaSkrynnik/extended
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-firewall-vpp that referenced this pull request Nov 28, 2024
Update go.mod and go.sum to latest version from networkservicemesh/vp…
12d69e9 
…phelper@main

PR link: networkservicemesh/vpphelper#9

Commit: f488145
Author: Denis Tingaikin
Date: 2024-11-28 05:43:52 -0500
Message:
  - Merge pull request #9 from NikitaSkrynnik/extended
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vlan-vpp that referenced this pull request Nov 28, 2024
Update go.mod and go.sum to latest version from networkservicemesh/vp…
e1ceb93 
…phelper@main

PR link: networkservicemesh/vpphelper#9

Commit: f488145
Author: Denis Tingaikin
Date: 2024-11-28 05:43:52 -0500
Message:
  - Merge pull request #9 from NikitaSkrynnik/extended
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-simple-docker that referenced this pull request Nov 28, 2024
Update go.mod and go.sum to latest version from networkservicemesh/vp…
274395f 
…phelper@main

PR link: networkservicemesh/vpphelper#9

Commit: f488145
Author: Denis Tingaikin
Date: 2024-11-28 05:43:52 -0500
Message:
  - Merge pull request #9 from NikitaSkrynnik/extended
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vl3-vpp that referenced this pull request Nov 28, 2024
Update go.mod and go.sum to latest version from networkservicemesh/vp…
827c7a0 
…phelper@main

PR link: networkservicemesh/vpphelper#9

Commit: f488145
Author: Denis Tingaikin
Date: 2024-11-28 05:43:52 -0500
Message:
  - Merge pull request #9 from NikitaSkrynnik/extended
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Nov 28, 2024
Merged
Merged
Merged
nsmbot added a commit to networkservicemesh/cmd-nse-firewall-vpp that referenced this pull request Nov 28, 2024
@nsmbot
Update go.mod and go.sum to latest version from networkservicemesh/vp…
3397732 
…phelper@main (#555)

PR link: networkservicemesh/vpphelper#9

Commit: f488145
Author: Denis Tingaikin
Date: 2024-11-28 05:43:52 -0500
Message:
  - Merge pull request #9 from NikitaSkrynnik/extended

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot added a commit to networkservicemesh/cmd-nsc-vpp that referenced this pull request Nov 28, 2024
@nsmbot
Update go.mod and go.sum to latest version from networkservicemesh/vp…
a16850b 
…phelper@main (#737)

PR link: networkservicemesh/vpphelper#9

Commit: f488145
Author: Denis Tingaikin
Date: 2024-11-28 05:43:52 -0500
Message:
  - Merge pull request #9 from NikitaSkrynnik/extended

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot added a commit to networkservicemesh/cmd-nse-icmp-responder-vpp that referenced this pull request Nov 28, 2024
@nsmbot
Update go.mod and go.sum to latest version from networkservicemesh/vp…
1b00e89 
…phelper@main (#719)

PR link: networkservicemesh/vpphelper#9

Commit: f488145
Author: Denis Tingaikin
Date: 2024-11-28 05:43:52 -0500
Message:
  - Merge pull request #9 from NikitaSkrynnik/extended

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/deployments-k8s that referenced this pull request Nov 28, 2024
Update go.mod and go.sum to latest version from networkservicemesh/cm…
ae2c760 
…d-nsc-vpp@main

PR link: networkservicemesh/cmd-nsc-vpp#737

Commit: a16850b
Author: Network Service Mesh Bot
Date: 2024-11-28 04:46:40 -0600
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/vpphelper@main (#737)
PR link: networkservicemesh/vpphelper#9
Commit: f488145
Author: Denis Tingaikin
Date: 2024-11-28 05:43:52 -0500
Message:
    - Merge pull request #9 from NikitaSkrynnik/extended
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/deployments-k8s that referenced this pull request Nov 28, 2024
Update go.mod and go.sum to latest version from networkservicemesh/cm…
832a4b2 
…d-nse-firewall-vpp@main

PR link: networkservicemesh/cmd-nse-firewall-vpp#555

Commit: 3397732
Author: Network Service Mesh Bot
Date: 2024-11-28 04:46:39 -0600
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/vpphelper@main (#555)
PR link: networkservicemesh/vpphelper#9
Commit: f488145
Author: Denis Tingaikin
Date: 2024-11-28 05:43:52 -0500
Message:
    - Merge pull request #9 from NikitaSkrynnik/extended
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/deployments-k8s that referenced this pull request Nov 28, 2024
Update go.mod and go.sum to latest version from networkservicemesh/cm…
b4465cf 
…d-nse-icmp-responder-vpp@main

PR link: networkservicemesh/cmd-nse-icmp-responder-vpp#719

Commit: 1b00e89
Author: Network Service Mesh Bot
Date: 2024-11-28 04:46:42 -0600
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/vpphelper@main (#719)
PR link: networkservicemesh/vpphelper#9
Commit: f488145
Author: Denis Tingaikin
Date: 2024-11-28 05:43:52 -0500
Message:
    - Merge pull request #9 from NikitaSkrynnik/extended
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
@nsmbot nsmbot mentioned this pull request Nov 28, 2024
Merged
nsmbot added a commit to networkservicemesh/deployments-k8s that referenced this pull request Nov 28, 2024
@nsmbot
Update go.mod and go.sum to latest version from networkservicemesh/cm…
36af411 
…d-nsc-vpp@main (#12569)

PR link: networkservicemesh/cmd-nsc-vpp#737

Commit: a16850b
Author: Network Service Mesh Bot
Date: 2024-11-28 04:46:40 -0600
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/vpphelper@main (#737)
PR link: networkservicemesh/vpphelper#9
Commit: f488145
Author: Denis Tingaikin
Date: 2024-11-28 05:43:52 -0500
Message:
    - Merge pull request #9 from NikitaSkrynnik/extended

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
@NikitaSkrynnik NikitaSkrynnik mentioned this pull request Nov 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-tingaikin denis-tingaikin denis-tingaikin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NikitaSkrynnik @denis-tingaikin