Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make onidle disable itself when timeout is set to 0 #929

Merged
merged 3 commits into from
May 18, 2021
Merged

Make onidle disable itself when timeout is set to 0 #929

merged 3 commits into from
May 18, 2021

Conversation

d-uzlov
Copy link
Contributor

@d-uzlov d-uzlov commented May 17, 2021

Issue link

fixes #928

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionallity
  • Documentation
  • Refactoring
  • CI

d-uzlov added 2 commits May 17, 2021 17:12
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
@denis-tingaikin
Copy link
Member

As I can see this is related to networkservicemesh/cmd-nse-icmp-responder#188 (comment)

@edwarnicke Could you look at this PR?

Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
@edwarnicke edwarnicke merged commit a305f69 into networkservicemesh:main May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make onidle disable itself when timeout is set to 0
3 participants