-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: go generate check doesn't fail in case if found diff + re-generate stuff #685
Merged
haiodo
merged 1 commit into
networkservicemesh:master
from
denis-tingaikin:regenerate-stuff
Feb 1, 2021
Merged
fix: go generate check doesn't fail in case if found diff + re-generate stuff #685
haiodo
merged 1 commit into
networkservicemesh:master
from
denis-tingaikin:regenerate-stuff
Feb 1, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erate sync map to latest go Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
denis-tingaikin
force-pushed
the
regenerate-stuff
branch
from
January 29, 2021 13:13
5302ca8
to
396957f
Compare
denis-tingaikin
changed the title
fix: go generate check doesn't fail in case if found diff ci + re-generate sync map to latest go 1.15
fix: go generate check doesn't fail in case if found diff + commit go generate ./... changes
Jan 29, 2021
denis-tingaikin
changed the title
fix: go generate check doesn't fail in case if found diff + commit go generate ./... changes
fix: go generate check doesn't fail in case if found diff + re-generate stuff
Jan 29, 2021
haiodo
approved these changes
Feb 1, 2021
nsmbot
pushed a commit
to networkservicemesh/sdk-vpp
that referenced
this pull request
Feb 1, 2021
…k@master networkservicemesh/sdk#685 networkservicemesh/sdk PR link: networkservicemesh/sdk#685 networkservicemesh/sdk commit message: commit 4592ea06d8e1c329c882419ff318a5ce6151909d Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com> Date: Mon Feb 1 12:12:20 2021 +0700 fix: go generate check doesn't fail in case if found diff ci + re-generate sync map to latest go (#685) Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Feb 1, 2021
…k@master networkservicemesh/sdk#685 networkservicemesh/sdk PR link: networkservicemesh/sdk#685 networkservicemesh/sdk commit message: commit 4592ea06d8e1c329c882419ff318a5ce6151909d Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com> Date: Mon Feb 1 12:12:20 2021 +0700 fix: go generate check doesn't fail in case if found diff ci + re-generate sync map to latest go (#685) Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Feb 1, 2021
…k@master networkservicemesh/sdk#685 networkservicemesh/sdk PR link: networkservicemesh/sdk#685 networkservicemesh/sdk commit message: commit 4592ea06d8e1c329c882419ff318a5ce6151909d Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com> Date: Mon Feb 1 12:12:20 2021 +0700 fix: go generate check doesn't fail in case if found diff ci + re-generate sync map to latest go (#685) Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Feb 1, 2021
…k@master networkservicemesh/sdk#685 networkservicemesh/sdk PR link: networkservicemesh/sdk#685 networkservicemesh/sdk commit message: commit 4592ea06d8e1c329c882419ff318a5ce6151909d Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com> Date: Mon Feb 1 12:12:20 2021 +0700 fix: go generate check doesn't fail in case if found diff ci + re-generate sync map to latest go (#685) Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Feb 1, 2021
…k@master networkservicemesh/sdk#685 networkservicemesh/sdk PR link: networkservicemesh/sdk#685 networkservicemesh/sdk commit message: commit 4592ea06d8e1c329c882419ff318a5ce6151909d Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com> Date: Mon Feb 1 12:12:20 2021 +0700 fix: go generate check doesn't fail in case if found diff ci + re-generate sync map to latest go (#685) Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-icmp-responder
that referenced
this pull request
Feb 1, 2021
…k@master networkservicemesh/sdk#685 networkservicemesh/sdk PR link: networkservicemesh/sdk#685 networkservicemesh/sdk commit message: commit 4592ea06d8e1c329c882419ff318a5ce6151909d Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com> Date: Mon Feb 1 12:12:20 2021 +0700 fix: go generate check doesn't fail in case if found diff ci + re-generate sync map to latest go (#685) Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Feb 1, 2021
…k@master networkservicemesh/sdk#685 networkservicemesh/sdk PR link: networkservicemesh/sdk#685 networkservicemesh/sdk commit message: commit 4592ea06d8e1c329c882419ff318a5ce6151909d Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com> Date: Mon Feb 1 12:12:20 2021 +0700 fix: go generate check doesn't fail in case if found diff ci + re-generate sync map to latest go (#685) Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Feb 1, 2021
…k@master networkservicemesh/sdk#685 networkservicemesh/sdk PR link: networkservicemesh/sdk#685 networkservicemesh/sdk commit message: commit 4592ea06d8e1c329c882419ff318a5ce6151909d Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com> Date: Mon Feb 1 12:12:20 2021 +0700 fix: go generate check doesn't fail in case if found diff ci + re-generate sync map to latest go (#685) Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Feb 1, 2021
…k@master networkservicemesh/sdk#685 networkservicemesh/sdk PR link: networkservicemesh/sdk#685 networkservicemesh/sdk commit message: commit 4592ea06d8e1c329c882419ff318a5ce6151909d Author: Denis Tingaikin <49399980+denis-tingaikin@users.noreply.github.com> Date: Mon Feb 1 12:12:20 2021 +0700 fix: go generate check doesn't fail in case if found diff ci + re-generate sync map to latest go (#685) Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Denis Tingaikin denis.tingajkin@xored.com