Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with storing invalid URL in interpose registry #574

Merged
merged 2 commits into from
Nov 6, 2020
Merged

Fix issue with storing invalid URL in interpose registry #574

merged 2 commits into from
Nov 6, 2020

Conversation

Bolodya1997
Copy link

@Bolodya1997 Bolodya1997 commented Nov 6, 2020 •
edited
Loading

Issue

NSMgr stores inode:// URL in interpose registry and then fails to access forwarder.

Solution

    newRecvFDEndpointRegistry(), // <-- first replace `inode` URL with `unix` URL
    urlsRegistryServer, // <-- then store it into the interpose registry

Fix excludePrefixesServer
ced65bf 
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Fix nsmgr registry chain order
5ff22b9 
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
@Bolodya1997 Bolodya1997 changed the title Small fixes Fix issue with storing invalid URL in interpose registry Nov 6, 2020
@denis-tingaikin denis-tingaikin merged commit 1bde5f0 into networkservicemesh:master Nov 6, 2020
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Nov 6, 2020
Update go.mod and go.sum to latest version from networkservicemesh/sd…
4c09eb2 
…k@master networkservicemesh/sdk#574

networkservicemesh/sdk PR link: networkservicemesh/sdk#574

networkservicemesh/sdk commit message:
commit 1bde5f0f1aebfff401c42e856035f3856d00e669
Author: Vladimir Popov <vladimir.popov@xored.com>
Date:   Fri Nov 6 21:11:03 2020 +0700

    Fix issue with storing invalid URL in interpose registry (#574)

    * Fix excludePrefixesServer

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

    * Fix nsmgr registry chain order

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Nov 6, 2020
Update go.mod and go.sum to latest version from networkservicemesh/sd…
3cb5b09 
…k@master networkservicemesh/sdk#574

networkservicemesh/sdk PR link: networkservicemesh/sdk#574

networkservicemesh/sdk commit message:
commit 1bde5f0f1aebfff401c42e856035f3856d00e669
Author: Vladimir Popov <vladimir.popov@xored.com>
Date:   Fri Nov 6 21:11:03 2020 +0700

    Fix issue with storing invalid URL in interpose registry (#574)

    * Fix excludePrefixesServer

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

    * Fix nsmgr registry chain order

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Nov 6, 2020
Update go.mod and go.sum to latest version from networkservicemesh/sd…
a7dbeb9 
…k@master networkservicemesh/sdk#574

networkservicemesh/sdk PR link: networkservicemesh/sdk#574

networkservicemesh/sdk commit message:
commit 1bde5f0f1aebfff401c42e856035f3856d00e669
Author: Vladimir Popov <vladimir.popov@xored.com>
Date:   Fri Nov 6 21:11:03 2020 +0700

    Fix issue with storing invalid URL in interpose registry (#574)

    * Fix excludePrefixesServer

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

    * Fix nsmgr registry chain order

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-vppagent that referenced this pull request Nov 6, 2020
Update go.mod and go.sum to latest version from networkservicemesh/sd…
8e2ece3 
…k@master networkservicemesh/sdk#574

networkservicemesh/sdk PR link: networkservicemesh/sdk#574

networkservicemesh/sdk commit message:
commit 1bde5f0f1aebfff401c42e856035f3856d00e669
Author: Vladimir Popov <vladimir.popov@xored.com>
Date:   Fri Nov 6 21:11:03 2020 +0700

    Fix issue with storing invalid URL in interpose registry (#574)

    * Fix excludePrefixesServer

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

    * Fix nsmgr registry chain order

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-icmp-responder that referenced this pull request Nov 6, 2020
Update go.mod and go.sum to latest version from networkservicemesh/sd…
cc2f50c 
…k@master networkservicemesh/sdk#574

networkservicemesh/sdk PR link: networkservicemesh/sdk#574

networkservicemesh/sdk commit message:
commit 1bde5f0f1aebfff401c42e856035f3856d00e669
Author: Vladimir Popov <vladimir.popov@xored.com>
Date:   Fri Nov 6 21:11:03 2020 +0700

    Fix issue with storing invalid URL in interpose registry (#574)

    * Fix excludePrefixesServer

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

    * Fix nsmgr registry chain order

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Nov 6, 2020
Update go.mod and go.sum to latest version from networkservicemesh/sd…
9fc26d4 
…k@master networkservicemesh/sdk#574

networkservicemesh/sdk PR link: networkservicemesh/sdk#574

networkservicemesh/sdk commit message:
commit 1bde5f0f1aebfff401c42e856035f3856d00e669
Author: Vladimir Popov <vladimir.popov@xored.com>
Date:   Fri Nov 6 21:11:03 2020 +0700

    Fix issue with storing invalid URL in interpose registry (#574)

    * Fix excludePrefixesServer

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

    * Fix nsmgr registry chain order

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Nov 6, 2020
Update go.mod and go.sum to latest version from networkservicemesh/sd…
2325d31 
…k@master networkservicemesh/sdk#574

networkservicemesh/sdk PR link: networkservicemesh/sdk#574

networkservicemesh/sdk commit message:
commit 1bde5f0f1aebfff401c42e856035f3856d00e669
Author: Vladimir Popov <vladimir.popov@xored.com>
Date:   Fri Nov 6 21:11:03 2020 +0700

    Fix issue with storing invalid URL in interpose registry (#574)

    * Fix excludePrefixesServer

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

    * Fix nsmgr registry chain order

    Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
@Bolodya1997 Bolodya1997 deleted the fix branch November 12, 2020 09:56
illbegood pushed a commit to illbegood/sdk that referenced this pull request Dec 20, 2020
Fix issue with storing invalid URL in interpose registry (networkserv…
6bd3593 
…icemesh#574)

* Fix excludePrefixesServer

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

* Fix nsmgr registry chain order

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Signed-off-by: Sergey Ershov <sergey.ershov@xored.com>
illbegood pushed a commit to illbegood/sdk that referenced this pull request Dec 23, 2020
Fix issue with storing invalid URL in interpose registry (networkserv…
a922092 
…icemesh#574)

* Fix excludePrefixesServer

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>

* Fix nsmgr registry chain order

Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
Signed-off-by: Sergey Ershov <sergey.ershov@xored.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-tingaikin denis-tingaikin denis-tingaikin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bolodya1997 @denis-tingaikin