Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use network service for generating iface name on nse side #1644

Merged
merged 3 commits into from
Jul 3, 2024
Merged

Use network service for generating iface name on nse side #1644

merged 3 commits into from
Jul 3, 2024

Conversation

denis-tingaikin
Copy link
Member

@denis-tingaikin denis-tingaikin commented Jun 29, 2024 •
edited
Loading

Description

Current iface naming format is nsm%id in the main branch (release v1.13.1)
Previous iface naming format is $networkServiceName-$id

PR returns the previous iface name conversion to respond on #1589 (comment)

Issue link

Closes #1589

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionality
  • Documentation
  • Refactoring
  • CI

@denis-tingaikin
use network service for generating iface name on nse side
0a3de65 
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
@denis-tingaikin
Copy link
Member Author

/cc @olahg

@denis-tingaikin denis-tingaikin marked this pull request as ready for review June 29, 2024 07:42
@denis-tingaikin
update alphabet
c91315f 
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
@denis-tingaikin denis-tingaikin mentioned this pull request Jul 1, 2024
Closed
@denis-tingaikin
fix tests
0d470b1 
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
denis-tingaikin
denis-tingaikin commented Jul 1, 2024
View reviewed changes
pkg/tools/nanoid/generator.go Outdated
@@ -26,7 +26,7 @@ import (

const (
// DefaultAlphabet is the default alphabet for the generator which can be used to generate kernel interface names
DefaultAlphabet = "!\"#$&'()*+,-.0123456789;<=>?@ABCDEFGHIJKLMNOPQRSTUVWXYZ[\\]^_`abcdefghijklmnopqrstuvwxyz{|}~"
Copy link
Member Author

@denis-tingaikin denis-tingaikin Jul 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This alphabet beats v1.11.2 about 10 times by collision probability.

denis-tingaikin
denis-tingaikin commented Jul 1, 2024
View reviewed changes
pkg/tools/nanoid/generator.go
@@ -26,7 +26,7 @@ import (

const (
// DefaultAlphabet is the default alphabet for the generator which can be used to generate kernel interface names
DefaultAlphabet = "!\"#$&'()*+,-.0123456789;<=>?@ABCDEFGHIJKLMNOPQRSTUVWXYZ[\\]^_`abcdefghijklmnopqrstuvwxyz{|}~"
DefaultAlphabet = "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This alphabet beats v1.11.2 about twice by collision probability

@edwarnicke edwarnicke merged commit 73a3c05 into main Jul 3, 2024
15 checks passed
nsmbot pushed a commit to networkservicemesh/cmd-csi-driver that referenced this pull request Jul 3, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
c01d7e4 
…k@main

PR link: networkservicemesh/sdk#1644

Commit: 73a3c05
Author: Denis Tingaikin
Date: 2024-07-03 17:03:52 +0300
Message:
  - Use network service for generating iface name on nse side (#1644)
* use network service for generating iface name on nse side

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* update alphabet

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix tests

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-cluster-info-k8s that referenced this pull request Jul 3, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
856574e 
…k@main

PR link: networkservicemesh/sdk#1644

Commit: 73a3c05
Author: Denis Tingaikin
Date: 2024-07-03 17:03:52 +0300
Message:
  - Use network service for generating iface name on nse side (#1644)
* use network service for generating iface name on nse side

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* update alphabet

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix tests

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Jul 3, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
953bc8e 
…k@main

PR link: networkservicemesh/sdk#1644

Commit: 73a3c05
Author: Denis Tingaikin
Date: 2024-07-03 17:03:52 +0300
Message:
  - Use network service for generating iface name on nse side (#1644)
* use network service for generating iface name on nse side

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* update alphabet

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix tests

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this pull request Jul 3, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
42ef117 
…k@main

PR link: networkservicemesh/sdk#1644

Commit: 73a3c05
Author: Denis Tingaikin
Date: 2024-07-03 17:03:52 +0300
Message:
  - Use network service for generating iface name on nse side (#1644)
* use network service for generating iface name on nse side

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* update alphabet

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix tests

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-ipam-vl3 that referenced this pull request Jul 3, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
5fac7d3 
…k@main

PR link: networkservicemesh/sdk#1644

Commit: 73a3c05
Author: Denis Tingaikin
Date: 2024-07-03 17:03:52 +0300
Message:
  - Use network service for generating iface name on nse side (#1644)
* use network service for generating iface name on nse side

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* update alphabet

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix tests

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-dashboard-backend that referenced this pull request Jul 3, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
d26268c 
…k@main

PR link: networkservicemesh/sdk#1644

Commit: 73a3c05
Author: Denis Tingaikin
Date: 2024-07-03 17:03:52 +0300
Message:
  - Use network service for generating iface name on nse side (#1644)
* use network service for generating iface name on nse side

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* update alphabet

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix tests

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Jul 3, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
5c4b7d0 
…k@main

PR link: networkservicemesh/sdk#1644

Commit: 73a3c05
Author: Denis Tingaikin
Date: 2024-07-03 17:03:52 +0300
Message:
  - Use network service for generating iface name on nse side (#1644)
* use network service for generating iface name on nse side

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* update alphabet

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix tests

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Jul 3, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
903c5d0 
…k@main

PR link: networkservicemesh/sdk#1644

Commit: 73a3c05
Author: Denis Tingaikin
Date: 2024-07-03 17:03:52 +0300
Message:
  - Use network service for generating iface name on nse side (#1644)
* use network service for generating iface name on nse side

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* update alphabet

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix tests

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Jul 3, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
eacf08d 
…k@main

PR link: networkservicemesh/sdk#1644

Commit: 73a3c05
Author: Denis Tingaikin
Date: 2024-07-03 17:03:52 +0300
Message:
  - Use network service for generating iface name on nse side (#1644)
* use network service for generating iface name on nse side

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* update alphabet

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix tests

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Jul 3, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
d0eb5d1 
…k@main

PR link: networkservicemesh/sdk#1644

Commit: 73a3c05
Author: Denis Tingaikin
Date: 2024-07-03 17:03:52 +0300
Message:
  - Use network service for generating iface name on nse side (#1644)
* use network service for generating iface name on nse side

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* update alphabet

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix tests

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Jul 3, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
3c81cdc 
…k@main

PR link: networkservicemesh/sdk#1644

Commit: 73a3c05
Author: Denis Tingaikin
Date: 2024-07-03 17:03:52 +0300
Message:
  - Use network service for generating iface name on nse side (#1644)
* use network service for generating iface name on nse side

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* update alphabet

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix tests

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Jul 3, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
7fb1ff5 
…k@main

PR link: networkservicemesh/sdk#1644

Commit: 73a3c05
Author: Denis Tingaikin
Date: 2024-07-03 17:03:52 +0300
Message:
  - Use network service for generating iface name on nse side (#1644)
* use network service for generating iface name on nse side

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* update alphabet

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix tests

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request Jul 3, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
0cc3d9e 
…k@main

PR link: networkservicemesh/sdk#1644

Commit: 73a3c05
Author: Denis Tingaikin
Date: 2024-07-03 17:03:52 +0300
Message:
  - Use network service for generating iface name on nse side (#1644)
* use network service for generating iface name on nse side

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* update alphabet

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix tests

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Jul 3, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
c5da77f 
…k@main

PR link: networkservicemesh/sdk#1644

Commit: 73a3c05
Author: Denis Tingaikin
Date: 2024-07-03 17:03:52 +0300
Message:
  - Use network service for generating iface name on nse side (#1644)
* use network service for generating iface name on nse side

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* update alphabet

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix tests

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Jul 3, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
0993ebc 
…k@main

PR link: networkservicemesh/sdk#1644

Commit: 73a3c05
Author: Denis Tingaikin
Date: 2024-07-03 17:03:52 +0300
Message:
  - Use network service for generating iface name on nse side (#1644)
* use network service for generating iface name on nse side

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* update alphabet

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix tests

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
@nsmbot nsmbot mentioned this pull request Jul 3, 2024
Merged
NikitaSkrynnik pushed a commit to NikitaSkrynnik/sdk that referenced this pull request Jul 25, 2024
@denis-tingaikin @NikitaSkrynnik
Use network service for generating iface name on nse side (networkser…
16b5ab1 
…vicemesh#1644)

* use network service for generating iface name on nse side

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* update alphabet

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix tests

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

---------

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
NikitaSkrynnik pushed a commit to NikitaSkrynnik/sdk that referenced this pull request Jul 29, 2024
@denis-tingaikin @NikitaSkrynnik
Use network service for generating iface name on nse side (networkser…
16202c7 
…vicemesh#1644)

* use network service for generating iface name on nse side

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* update alphabet

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix tests

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

---------

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szvincze szvincze szvincze approved these changes

@edwarnicke edwarnicke edwarnicke approved these changes

@NikitaSkrynnik NikitaSkrynnik Awaiting requested review from NikitaSkrynnik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Too high probability of name collision in getNameFromConnection
3 participants
@denis-tingaikin @edwarnicke @szvincze