Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate random kernel interface names #1590

Merged
merged 8 commits into from
Mar 21, 2024
Merged

Generate random kernel interface names #1590

merged 8 commits into from
Mar 21, 2024

Conversation

NikitaSkrynnik
Copy link
Contributor

@NikitaSkrynnik NikitaSkrynnik commented Mar 12, 2024 •
edited
Loading

Description

Generate random kernel interface names of a form nsm############ where # is a random character.

Issue link

#1589

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionality
  • Documentation
  • Refactoring
  • CI

@NikitaSkrynnik
Generate kernel interface name
2b241e8 
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
@NikitaSkrynnik
fix linter issues + move the generator to tools folder
bf3a93f 
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
@NikitaSkrynnik NikitaSkrynnik marked this pull request as draft March 12, 2024 10:59
@NikitaSkrynnik NikitaSkrynnik marked this pull request as ready for review March 12, 2024 11:10
@NikitaSkrynnik
cleanup + fix some tests
ec17f46 
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
@codecov Codecov
Copy link

codecov bot commented Mar 12, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 73.73737% with 26 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@b1a3e26). Click here to learn what that means.

Files Patch % Lines
pkg/tools/nanoid/generator.go 70.21% 12 Missing and 2 partials ⚠️
.../networkservice/common/mechanisms/kernel/server.go 0.00% 10 Missing ⚠️
.../networkservice/common/mechanisms/kernel/client.go 93.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1590   +/-   ##
=======================================
  Coverage        ?   67.35%           
=======================================
  Files           ?      262           
  Lines           ?    12450           
  Branches        ?        0           
=======================================
  Hits            ?     8386           
  Misses          ?     3540           
  Partials        ?      524

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

denis-tingaikin
denis-tingaikin reviewed Mar 12, 2024
View reviewed changes
Copy link
Member

@denis-tingaikin denis-tingaikin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, LGTM

Please add more info for folks in the comments about algorithm guarantees. Also, let's do cover warnings from the codecov job.

pkg/tools/nanoid/generator.go Show resolved Hide resolved
denis-tingaikin
denis-tingaikin requested changes Mar 12, 2024
View reviewed changes
pkg/tools/nanoid/generator.go Outdated Show resolved Hide resolved
@NikitaSkrynnik
fix review comments
602404d 
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
@NikitaSkrynnik
rerun CI
d67475d 
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
@NikitaSkrynnik
fix review comments + add more code coverage with tests
ca20a27 
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
@NikitaSkrynnik
fix golang linter issues
2e121cf 
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
@NikitaSkrynnik
fix review comments
49c140b 
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
@denis-tingaikin denis-tingaikin merged commit f5e9a5c into networkservicemesh:main Mar 21, 2024
17 checks passed
nsmbot pushed a commit to networkservicemesh/cmd-csi-driver that referenced this pull request Mar 21, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
2f07ff7 
…k@main

PR link: networkservicemesh/sdk#1590

Commit: f5e9a5c
Author: Nikita Skrynnik
Date: 2024-03-21 16:48:16 +0700
Message:
  - Generate random kernel interface names (#1590)
* Generate kernel interface name

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix linter issues + move the generator to tools folder

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* cleanup + fix some tests

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix review comments

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* rerun CI

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix review comments + add more code coverage with tests

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix golang linter issues

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix review comments

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-cluster-info-k8s that referenced this pull request Mar 21, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
cc93aed 
…k@main

PR link: networkservicemesh/sdk#1590

Commit: f5e9a5c
Author: Nikita Skrynnik
Date: 2024-03-21 16:48:16 +0700
Message:
  - Generate random kernel interface names (#1590)
* Generate kernel interface name

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix linter issues + move the generator to tools folder

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* cleanup + fix some tests

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix review comments

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* rerun CI

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix review comments + add more code coverage with tests

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix golang linter issues

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix review comments

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-ipam-vl3 that referenced this pull request Mar 21, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
f796f2e 
…k@main

PR link: networkservicemesh/sdk#1590

Commit: f5e9a5c
Author: Nikita Skrynnik
Date: 2024-03-21 16:48:16 +0700
Message:
  - Generate random kernel interface names (#1590)
* Generate kernel interface name

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix linter issues + move the generator to tools folder

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* cleanup + fix some tests

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix review comments

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* rerun CI

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix review comments + add more code coverage with tests

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix golang linter issues

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix review comments

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this pull request Mar 21, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
d7e6d81 
…k@main

PR link: networkservicemesh/sdk#1590

Commit: f5e9a5c
Author: Nikita Skrynnik
Date: 2024-03-21 16:48:16 +0700
Message:
  - Generate random kernel interface names (#1590)
* Generate kernel interface name

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix linter issues + move the generator to tools folder

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* cleanup + fix some tests

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix review comments

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* rerun CI

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix review comments + add more code coverage with tests

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix golang linter issues

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix review comments

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Mar 21, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
1e487ba 
…k@main

PR link: networkservicemesh/sdk#1590

Commit: f5e9a5c
Author: Nikita Skrynnik
Date: 2024-03-21 16:48:16 +0700
Message:
  - Generate random kernel interface names (#1590)
* Generate kernel interface name

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix linter issues + move the generator to tools folder

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* cleanup + fix some tests

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix review comments

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* rerun CI

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix review comments + add more code coverage with tests

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix golang linter issues

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix review comments

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-dashboard-backend that referenced this pull request Mar 21, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
7525c10 
…k@main

PR link: networkservicemesh/sdk#1590

Commit: f5e9a5c
Author: Nikita Skrynnik
Date: 2024-03-21 16:48:16 +0700
Message:
  - Generate random kernel interface names (#1590)
* Generate kernel interface name

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix linter issues + move the generator to tools folder

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* cleanup + fix some tests

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix review comments

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* rerun CI

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix review comments + add more code coverage with tests

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix golang linter issues

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix review comments

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Mar 21, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
c42411e 
…k@main

PR link: networkservicemesh/sdk#1590

Commit: f5e9a5c
Author: Nikita Skrynnik
Date: 2024-03-21 16:48:16 +0700
Message:
  - Generate random kernel interface names (#1590)
* Generate kernel interface name

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix linter issues + move the generator to tools folder

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* cleanup + fix some tests

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix review comments

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* rerun CI

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix review comments + add more code coverage with tests

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix golang linter issues

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix review comments

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Mar 21, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
36aaf56 
…k@main

PR link: networkservicemesh/sdk#1590

Commit: f5e9a5c
Author: Nikita Skrynnik
Date: 2024-03-21 16:48:16 +0700
Message:
  - Generate random kernel interface names (#1590)
* Generate kernel interface name

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix linter issues + move the generator to tools folder

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* cleanup + fix some tests

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix review comments

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* rerun CI

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix review comments + add more code coverage with tests

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix golang linter issues

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix review comments

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Mar 21, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
e23c3d1 
…k@main

PR link: networkservicemesh/sdk#1590

Commit: f5e9a5c
Author: Nikita Skrynnik
Date: 2024-03-21 16:48:16 +0700
Message:
  - Generate random kernel interface names (#1590)
* Generate kernel interface name

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix linter issues + move the generator to tools folder

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* cleanup + fix some tests

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix review comments

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* rerun CI

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix review comments + add more code coverage with tests

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix golang linter issues

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix review comments

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Mar 21, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
ae97796 
…k@main

PR link: networkservicemesh/sdk#1590

Commit: f5e9a5c
Author: Nikita Skrynnik
Date: 2024-03-21 16:48:16 +0700
Message:
  - Generate random kernel interface names (#1590)
* Generate kernel interface name

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix linter issues + move the generator to tools folder

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* cleanup + fix some tests

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix review comments

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* rerun CI

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix review comments + add more code coverage with tests

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix golang linter issues

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix review comments

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Mar 21, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
6d402e5 
…k@main

PR link: networkservicemesh/sdk#1590

Commit: f5e9a5c
Author: Nikita Skrynnik
Date: 2024-03-21 16:48:16 +0700
Message:
  - Generate random kernel interface names (#1590)
* Generate kernel interface name

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix linter issues + move the generator to tools folder

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* cleanup + fix some tests

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix review comments

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* rerun CI

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix review comments + add more code coverage with tests

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix golang linter issues

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix review comments

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request Mar 21, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
cc7bc4f 
…k@main

PR link: networkservicemesh/sdk#1590

Commit: f5e9a5c
Author: Nikita Skrynnik
Date: 2024-03-21 16:48:16 +0700
Message:
  - Generate random kernel interface names (#1590)
* Generate kernel interface name

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix linter issues + move the generator to tools folder

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* cleanup + fix some tests

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix review comments

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* rerun CI

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix review comments + add more code coverage with tests

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix golang linter issues

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix review comments

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Mar 21, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
090a9ca 
…k@main

PR link: networkservicemesh/sdk#1590

Commit: f5e9a5c
Author: Nikita Skrynnik
Date: 2024-03-21 16:48:16 +0700
Message:
  - Generate random kernel interface names (#1590)
* Generate kernel interface name

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix linter issues + move the generator to tools folder

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* cleanup + fix some tests

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix review comments

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* rerun CI

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix review comments + add more code coverage with tests

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix golang linter issues

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix review comments

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Mar 21, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
9792828 
…k@main

PR link: networkservicemesh/sdk#1590

Commit: f5e9a5c
Author: Nikita Skrynnik
Date: 2024-03-21 16:48:16 +0700
Message:
  - Generate random kernel interface names (#1590)
* Generate kernel interface name

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix linter issues + move the generator to tools folder

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* cleanup + fix some tests

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix review comments

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* rerun CI

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix review comments + add more code coverage with tests

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix golang linter issues

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix review comments

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Mar 21, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
abe5bca 
…k@main

PR link: networkservicemesh/sdk#1590

Commit: f5e9a5c
Author: Nikita Skrynnik
Date: 2024-03-21 16:48:16 +0700
Message:
  - Generate random kernel interface names (#1590)
* Generate kernel interface name

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix linter issues + move the generator to tools folder

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* cleanup + fix some tests

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix review comments

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* rerun CI

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix review comments + add more code coverage with tests

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix golang linter issues

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix review comments

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
@NikitaSkrynnik NikitaSkrynnik mentioned this pull request Apr 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-tingaikin denis-tingaikin denis-tingaikin approved these changes

@glazychev-art glazychev-art glazychev-art approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NikitaSkrynnik @glazychev-art @denis-tingaikin