-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete extra dependencies from workflow #1579
Merged
denis-tingaikin
merged 2 commits into
networkservicemesh:main
from
bellycat77:delete-extra-dependencies
Sep 24, 2024
Merged
Delete extra dependencies from workflow #1579
denis-tingaikin
merged 2 commits into
networkservicemesh:main
from
bellycat77:delete-extra-dependencies
Sep 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Osipov <bellycat77@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1579 +/- ##
=======================================
Coverage ? 67.25%
=======================================
Files ? 261
Lines ? 12382
Branches ? 0
=======================================
Hits ? 8327
Misses ? 3530
Partials ? 525 ☔ View full report in Codecov by Sentry. |
Please also check update-dependent-repositories-gomod.yaml |
Signed-off-by: Ivan Osipov <bellycat77@gmail.com>
Done |
denis-tingaikin
approved these changes
Sep 24, 2024
denis-tingaikin
approved these changes
Sep 24, 2024
nsmbot
pushed a commit
to networkservicemesh/cmd-csi-driver
that referenced
this pull request
Sep 24, 2024
…k@main PR link: networkservicemesh/sdk#1579 Commit: ebdf9cf Author: Ivan Osipov Date: 2024-09-24 14:21:34 +0400 Message: - Delete extra dependencies from workflow (#1579) * Delete extra dependencies from workflow Signed-off-by: Ivan Osipov <bellycat77@gmail.com> * Delete extra dependencies from workflow Signed-off-by: Ivan Osipov <bellycat77@gmail.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-map-ip-k8s
that referenced
this pull request
Sep 24, 2024
…k@main PR link: networkservicemesh/sdk#1579 Commit: ebdf9cf Author: Ivan Osipov Date: 2024-09-24 14:21:34 +0400 Message: - Delete extra dependencies from workflow (#1579) * Delete extra dependencies from workflow Signed-off-by: Ivan Osipov <bellycat77@gmail.com> * Delete extra dependencies from workflow Signed-off-by: Ivan Osipov <bellycat77@gmail.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-ipam-vl3
that referenced
this pull request
Sep 24, 2024
…k@main PR link: networkservicemesh/sdk#1579 Commit: ebdf9cf Author: Ivan Osipov Date: 2024-09-24 14:21:34 +0400 Message: - Delete extra dependencies from workflow (#1579) * Delete extra dependencies from workflow Signed-off-by: Ivan Osipov <bellycat77@gmail.com> * Delete extra dependencies from workflow Signed-off-by: Ivan Osipov <bellycat77@gmail.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-cluster-info-k8s
that referenced
this pull request
Sep 24, 2024
…k@main PR link: networkservicemesh/sdk#1579 Commit: ebdf9cf Author: Ivan Osipov Date: 2024-09-24 14:21:34 +0400 Message: - Delete extra dependencies from workflow (#1579) * Delete extra dependencies from workflow Signed-off-by: Ivan Osipov <bellycat77@gmail.com> * Delete extra dependencies from workflow Signed-off-by: Ivan Osipov <bellycat77@gmail.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Sep 24, 2024
…k@main PR link: networkservicemesh/sdk#1579 Commit: ebdf9cf Author: Ivan Osipov Date: 2024-09-24 14:21:34 +0400 Message: - Delete extra dependencies from workflow (#1579) * Delete extra dependencies from workflow Signed-off-by: Ivan Osipov <bellycat77@gmail.com> * Delete extra dependencies from workflow Signed-off-by: Ivan Osipov <bellycat77@gmail.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-dashboard-backend
that referenced
this pull request
Sep 24, 2024
…k@main PR link: networkservicemesh/sdk#1579 Commit: ebdf9cf Author: Ivan Osipov Date: 2024-09-24 14:21:34 +0400 Message: - Delete extra dependencies from workflow (#1579) * Delete extra dependencies from workflow Signed-off-by: Ivan Osipov <bellycat77@gmail.com> * Delete extra dependencies from workflow Signed-off-by: Ivan Osipov <bellycat77@gmail.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Sep 24, 2024
…k@main PR link: networkservicemesh/sdk#1579 Commit: ebdf9cf Author: Ivan Osipov Date: 2024-09-24 14:21:34 +0400 Message: - Delete extra dependencies from workflow (#1579) * Delete extra dependencies from workflow Signed-off-by: Ivan Osipov <bellycat77@gmail.com> * Delete extra dependencies from workflow Signed-off-by: Ivan Osipov <bellycat77@gmail.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Sep 24, 2024
…k@main PR link: networkservicemesh/sdk#1579 Commit: ebdf9cf Author: Ivan Osipov Date: 2024-09-24 14:21:34 +0400 Message: - Delete extra dependencies from workflow (#1579) * Delete extra dependencies from workflow Signed-off-by: Ivan Osipov <bellycat77@gmail.com> * Delete extra dependencies from workflow Signed-off-by: Ivan Osipov <bellycat77@gmail.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Sep 24, 2024
…k@main PR link: networkservicemesh/sdk#1579 Commit: ebdf9cf Author: Ivan Osipov Date: 2024-09-24 14:21:34 +0400 Message: - Delete extra dependencies from workflow (#1579) * Delete extra dependencies from workflow Signed-off-by: Ivan Osipov <bellycat77@gmail.com> * Delete extra dependencies from workflow Signed-off-by: Ivan Osipov <bellycat77@gmail.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Sep 24, 2024
…k@main PR link: networkservicemesh/sdk#1579 Commit: ebdf9cf Author: Ivan Osipov Date: 2024-09-24 14:21:34 +0400 Message: - Delete extra dependencies from workflow (#1579) * Delete extra dependencies from workflow Signed-off-by: Ivan Osipov <bellycat77@gmail.com> * Delete extra dependencies from workflow Signed-off-by: Ivan Osipov <bellycat77@gmail.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-remote-vlan
that referenced
this pull request
Sep 24, 2024
…k@main PR link: networkservicemesh/sdk#1579 Commit: ebdf9cf Author: Ivan Osipov Date: 2024-09-24 14:21:34 +0400 Message: - Delete extra dependencies from workflow (#1579) * Delete extra dependencies from workflow Signed-off-by: Ivan Osipov <bellycat77@gmail.com> * Delete extra dependencies from workflow Signed-off-by: Ivan Osipov <bellycat77@gmail.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Sep 24, 2024
…k@main PR link: networkservicemesh/sdk#1579 Commit: ebdf9cf Author: Ivan Osipov Date: 2024-09-24 14:21:34 +0400 Message: - Delete extra dependencies from workflow (#1579) * Delete extra dependencies from workflow Signed-off-by: Ivan Osipov <bellycat77@gmail.com> * Delete extra dependencies from workflow Signed-off-by: Ivan Osipov <bellycat77@gmail.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Sep 24, 2024
…k@main PR link: networkservicemesh/sdk#1579 Commit: ebdf9cf Author: Ivan Osipov Date: 2024-09-24 14:21:34 +0400 Message: - Delete extra dependencies from workflow (#1579) * Delete extra dependencies from workflow Signed-off-by: Ivan Osipov <bellycat77@gmail.com> * Delete extra dependencies from workflow Signed-off-by: Ivan Osipov <bellycat77@gmail.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Sep 24, 2024
This was referenced Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Two additional dependencies in workflow need to be removed
sdk
->cmd-nsc-init
(is extra forsdk
->sdk-kernel
->sdk-sriov
->cmd-nsc-init
)sdk
->cmd-admission-webhook-k8s
(is extra forsdk
->sdk-k8s
->cmd-admission-webhook-k8s
)Issue link
How Has This Been Tested?
Types of changes