Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete extra dependencies from workflow #1579

Merged

Conversation

bellycat77
Copy link
Contributor

Description

Two additional dependencies in workflow need to be removed

  1. sdk -> cmd-nsc-init (is extra for sdk -> sdk-kernel -> sdk-sriov -> cmd-nsc-init )
  2. sdk -> cmd-admission-webhook-k8s (is extra for sdk -> sdk-k8s -> cmd-admission-webhook-k8s )

Issue link

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionality
  • Documentation
  • Refactoring
  • CI

Signed-off-by: Ivan Osipov <bellycat77@gmail.com>
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@90f0c79). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1579   +/-   ##
=======================================
  Coverage        ?   67.25%           
=======================================
  Files           ?      261           
  Lines           ?    12382           
  Branches        ?        0           
=======================================
  Hits            ?     8327           
  Misses          ?     3530           
  Partials        ?      525           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glazychev-art
Copy link
Contributor

Please also check update-dependent-repositories-gomod.yaml

Signed-off-by: Ivan Osipov <bellycat77@gmail.com>
@bellycat77
Copy link
Contributor Author

Please also check update-dependent-repositories-gomod.yaml

Done

@denis-tingaikin denis-tingaikin merged commit ebdf9cf into networkservicemesh:main Sep 24, 2024
17 checks passed
nsmbot pushed a commit to networkservicemesh/cmd-csi-driver that referenced this pull request Sep 24, 2024
…k@main

PR link: networkservicemesh/sdk#1579

Commit: ebdf9cf
Author: Ivan Osipov
Date: 2024-09-24 14:21:34 +0400
Message:
  - Delete extra dependencies from workflow (#1579)
* Delete extra dependencies from workflow

Signed-off-by: Ivan Osipov <bellycat77@gmail.com>

* Delete extra dependencies from workflow

Signed-off-by: Ivan Osipov <bellycat77@gmail.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this pull request Sep 24, 2024
…k@main

PR link: networkservicemesh/sdk#1579

Commit: ebdf9cf
Author: Ivan Osipov
Date: 2024-09-24 14:21:34 +0400
Message:
  - Delete extra dependencies from workflow (#1579)
* Delete extra dependencies from workflow

Signed-off-by: Ivan Osipov <bellycat77@gmail.com>

* Delete extra dependencies from workflow

Signed-off-by: Ivan Osipov <bellycat77@gmail.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-ipam-vl3 that referenced this pull request Sep 24, 2024
…k@main

PR link: networkservicemesh/sdk#1579

Commit: ebdf9cf
Author: Ivan Osipov
Date: 2024-09-24 14:21:34 +0400
Message:
  - Delete extra dependencies from workflow (#1579)
* Delete extra dependencies from workflow

Signed-off-by: Ivan Osipov <bellycat77@gmail.com>

* Delete extra dependencies from workflow

Signed-off-by: Ivan Osipov <bellycat77@gmail.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-cluster-info-k8s that referenced this pull request Sep 24, 2024
…k@main

PR link: networkservicemesh/sdk#1579

Commit: ebdf9cf
Author: Ivan Osipov
Date: 2024-09-24 14:21:34 +0400
Message:
  - Delete extra dependencies from workflow (#1579)
* Delete extra dependencies from workflow

Signed-off-by: Ivan Osipov <bellycat77@gmail.com>

* Delete extra dependencies from workflow

Signed-off-by: Ivan Osipov <bellycat77@gmail.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Sep 24, 2024
…k@main

PR link: networkservicemesh/sdk#1579

Commit: ebdf9cf
Author: Ivan Osipov
Date: 2024-09-24 14:21:34 +0400
Message:
  - Delete extra dependencies from workflow (#1579)
* Delete extra dependencies from workflow

Signed-off-by: Ivan Osipov <bellycat77@gmail.com>

* Delete extra dependencies from workflow

Signed-off-by: Ivan Osipov <bellycat77@gmail.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-dashboard-backend that referenced this pull request Sep 24, 2024
…k@main

PR link: networkservicemesh/sdk#1579

Commit: ebdf9cf
Author: Ivan Osipov
Date: 2024-09-24 14:21:34 +0400
Message:
  - Delete extra dependencies from workflow (#1579)
* Delete extra dependencies from workflow

Signed-off-by: Ivan Osipov <bellycat77@gmail.com>

* Delete extra dependencies from workflow

Signed-off-by: Ivan Osipov <bellycat77@gmail.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Sep 24, 2024
…k@main

PR link: networkservicemesh/sdk#1579

Commit: ebdf9cf
Author: Ivan Osipov
Date: 2024-09-24 14:21:34 +0400
Message:
  - Delete extra dependencies from workflow (#1579)
* Delete extra dependencies from workflow

Signed-off-by: Ivan Osipov <bellycat77@gmail.com>

* Delete extra dependencies from workflow

Signed-off-by: Ivan Osipov <bellycat77@gmail.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Sep 24, 2024
…k@main

PR link: networkservicemesh/sdk#1579

Commit: ebdf9cf
Author: Ivan Osipov
Date: 2024-09-24 14:21:34 +0400
Message:
  - Delete extra dependencies from workflow (#1579)
* Delete extra dependencies from workflow

Signed-off-by: Ivan Osipov <bellycat77@gmail.com>

* Delete extra dependencies from workflow

Signed-off-by: Ivan Osipov <bellycat77@gmail.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Sep 24, 2024
…k@main

PR link: networkservicemesh/sdk#1579

Commit: ebdf9cf
Author: Ivan Osipov
Date: 2024-09-24 14:21:34 +0400
Message:
  - Delete extra dependencies from workflow (#1579)
* Delete extra dependencies from workflow

Signed-off-by: Ivan Osipov <bellycat77@gmail.com>

* Delete extra dependencies from workflow

Signed-off-by: Ivan Osipov <bellycat77@gmail.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Sep 24, 2024
…k@main

PR link: networkservicemesh/sdk#1579

Commit: ebdf9cf
Author: Ivan Osipov
Date: 2024-09-24 14:21:34 +0400
Message:
  - Delete extra dependencies from workflow (#1579)
* Delete extra dependencies from workflow

Signed-off-by: Ivan Osipov <bellycat77@gmail.com>

* Delete extra dependencies from workflow

Signed-off-by: Ivan Osipov <bellycat77@gmail.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request Sep 24, 2024
…k@main

PR link: networkservicemesh/sdk#1579

Commit: ebdf9cf
Author: Ivan Osipov
Date: 2024-09-24 14:21:34 +0400
Message:
  - Delete extra dependencies from workflow (#1579)
* Delete extra dependencies from workflow

Signed-off-by: Ivan Osipov <bellycat77@gmail.com>

* Delete extra dependencies from workflow

Signed-off-by: Ivan Osipov <bellycat77@gmail.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Sep 24, 2024
…k@main

PR link: networkservicemesh/sdk#1579

Commit: ebdf9cf
Author: Ivan Osipov
Date: 2024-09-24 14:21:34 +0400
Message:
  - Delete extra dependencies from workflow (#1579)
* Delete extra dependencies from workflow

Signed-off-by: Ivan Osipov <bellycat77@gmail.com>

* Delete extra dependencies from workflow

Signed-off-by: Ivan Osipov <bellycat77@gmail.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Sep 24, 2024
…k@main

PR link: networkservicemesh/sdk#1579

Commit: ebdf9cf
Author: Ivan Osipov
Date: 2024-09-24 14:21:34 +0400
Message:
  - Delete extra dependencies from workflow (#1579)
* Delete extra dependencies from workflow

Signed-off-by: Ivan Osipov <bellycat77@gmail.com>

* Delete extra dependencies from workflow

Signed-off-by: Ivan Osipov <bellycat77@gmail.com>

---------

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants