fix: do not choose endpoints that doesn't match the network service #1516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
denis-tingaikin
commented
Sep 25, 2023
Comment on lines
+632
to
+633
| require.Empty(t, matchutils.MatchEndpoint(map[string]string{}, ns, nseD), "there are no matches for nse-D") | ||
| require.Empty(t, matchutils.MatchEndpoint(map[string]string{"app": "nse-autoscaler"}, ns, nseD), "there are no matches for nse-D") |
There was a problem hiding this comment.
MatchEndpoint from main branch fails here
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1516 +/- ##
=======================================
Coverage ? 70.17%
=======================================
Files ? 248
Lines ? 11207
Branches ? 0
=======================================
Hits ? 7864
Misses ? 2843
Partials ? 500 ☔ View full report in Codecov by Sentry. |
|
This looks good to me, the only question is whether to merge this for 1.11 or wait for 1.12. @denis-tingaikin do you have an opinion there? |
|
@edwarnicke I think we might merge this into v1.11.0 right after all planned staff is merged, and if we fail, we could quickly revert this and continue working on it in the next release. |
glazychev-art
approved these changes
Oct 2, 2023
nsmbot
pushed a commit
to networkservicemesh/cmd-cluster-info-k8s
that referenced
this pull request
Oct 2, 2023
…k@main PR link: networkservicemesh/sdk#1516 Commit: f2a585e Author: Denis Tingaikin Date: 2023-10-02 13:32:15 +0300 Message: - do not choose endpoints that doesn't match with the network service (#1516) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-csi-driver
that referenced
this pull request
Oct 2, 2023
…k@main PR link: networkservicemesh/sdk#1516 Commit: f2a585e Author: Denis Tingaikin Date: 2023-10-02 13:32:15 +0300 Message: - do not choose endpoints that doesn't match with the network service (#1516) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-admission-webhook-k8s
that referenced
this pull request
Oct 2, 2023
…k@main PR link: networkservicemesh/sdk#1516 Commit: f2a585e Author: Denis Tingaikin Date: 2023-10-02 13:32:15 +0300 Message: - do not choose endpoints that doesn't match with the network service (#1516) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-remote-vlan
that referenced
this pull request
Oct 2, 2023
…k@main PR link: networkservicemesh/sdk#1516 Commit: f2a585e Author: Denis Tingaikin Date: 2023-10-02 13:32:15 +0300 Message: - do not choose endpoints that doesn't match with the network service (#1516) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Oct 2, 2023
…k@main PR link: networkservicemesh/sdk#1516 Commit: f2a585e Author: Denis Tingaikin Date: 2023-10-02 13:32:15 +0300 Message: - do not choose endpoints that doesn't match with the network service (#1516) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Oct 2, 2023
…k@main PR link: networkservicemesh/sdk#1516 Commit: f2a585e Author: Denis Tingaikin Date: 2023-10-02 13:32:15 +0300 Message: - do not choose endpoints that doesn't match with the network service (#1516) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-map-ip-k8s
that referenced
this pull request
Oct 2, 2023
…k@main PR link: networkservicemesh/sdk#1516 Commit: f2a585e Author: Denis Tingaikin Date: 2023-10-02 13:32:15 +0300 Message: - do not choose endpoints that doesn't match with the network service (#1516) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-ipam-vl3
that referenced
this pull request
Oct 2, 2023
…k@main PR link: networkservicemesh/sdk#1516 Commit: f2a585e Author: Denis Tingaikin Date: 2023-10-02 13:32:15 +0300 Message: - do not choose endpoints that doesn't match with the network service (#1516) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Oct 2, 2023
…k@main PR link: networkservicemesh/sdk#1516 Commit: f2a585e Author: Denis Tingaikin Date: 2023-10-02 13:32:15 +0300 Message: - do not choose endpoints that doesn't match with the network service (#1516) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Oct 2, 2023
…k@main PR link: networkservicemesh/sdk#1516 Commit: f2a585e Author: Denis Tingaikin Date: 2023-10-02 13:32:15 +0300 Message: - do not choose endpoints that doesn't match with the network service (#1516) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-init
that referenced
this pull request
Oct 2, 2023
…k@main PR link: networkservicemesh/sdk#1516 Commit: f2a585e Author: Denis Tingaikin Date: 2023-10-02 13:32:15 +0300 Message: - do not choose endpoints that doesn't match with the network service (#1516) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Oct 2, 2023
…k@main PR link: networkservicemesh/sdk#1516 Commit: f2a585e Author: Denis Tingaikin Date: 2023-10-02 13:32:15 +0300 Message: - do not choose endpoints that doesn't match with the network service (#1516) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Oct 2, 2023
…k@main PR link: networkservicemesh/sdk#1516 Commit: f2a585e Author: Denis Tingaikin Date: 2023-10-02 13:32:15 +0300 Message: - do not choose endpoints that doesn't match with the network service (#1516) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Oct 2, 2023
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Oct 2, 2023
…k@main PR link: networkservicemesh/sdk#1516 Commit: f2a585e Author: Denis Tingaikin Date: 2023-10-02 13:32:15 +0300 Message: - do not choose endpoints that doesn't match with the network service (#1516) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
do not choose endpoints that doesn't match with the network service
Issue link
How Has This Been Tested?
Types of changes