Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[qfix] vl3mtu: store cloned conn #1511

Merged
merged 1 commit into from
Sep 15, 2023
Merged

[qfix] vl3mtu: store cloned conn #1511

merged 1 commit into from
Sep 15, 2023

Conversation

glazychev-art
Copy link
Contributor

@glazychev-art glazychev-art commented Sep 14, 2023 •
edited
Loading

Description

Issue link

networkservicemesh/deployments-k8s#9210

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionality
  • Documentation
  • Refactoring
  • CI

@codecov
Copy link

codecov bot commented Sep 14, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@f96fdf6). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head fbfe4a2 differs from pull request most recent head 2821f2d. Consider uploading reports for the commit 2821f2d to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1511   +/-   ##
=======================================
  Coverage        ?   70.39%           
=======================================
  Files           ?      248           
  Lines           ?    11202           
  Branches        ?        0           
=======================================
  Hits            ?     7886           
  Misses          ?     2816           
  Partials        ?      500

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@denis-tingaikin
Copy link
Member

@glazychev-art Looks good. Can we add a small unit test for the change to avoid regressions?

@glazychev-art
[qfix] vl3mtu: store cloned conn
2821f2d 
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
@denis-tingaikin denis-tingaikin merged commit d68a6f4 into networkservicemesh:main Sep 15, 2023
nsmbot pushed a commit to networkservicemesh/cmd-ipam-vl3 that referenced this pull request Sep 15, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
371f135 
…k@main

PR link: networkservicemesh/sdk#1511

Commit: d68a6f4
Author: Artem Glazychev
Date: 2023-09-15 16:22:24 +0700
Message:
  - [qfix] vl3mtu: store cloned conn (#1511)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Sep 15, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
a00cc4d 
…k@main

PR link: networkservicemesh/sdk#1511

Commit: d68a6f4
Author: Artem Glazychev
Date: 2023-09-15 16:22:24 +0700
Message:
  - [qfix] vl3mtu: store cloned conn (#1511)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-cluster-info-k8s that referenced this pull request Sep 15, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
0a7eafa 
…k@main

PR link: networkservicemesh/sdk#1511

Commit: d68a6f4
Author: Artem Glazychev
Date: 2023-09-15 16:22:24 +0700
Message:
  - [qfix] vl3mtu: store cloned conn (#1511)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Sep 15, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
40edbd8 
…k@main

PR link: networkservicemesh/sdk#1511

Commit: d68a6f4
Author: Artem Glazychev
Date: 2023-09-15 16:22:24 +0700
Message:
  - [qfix] vl3mtu: store cloned conn (#1511)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this pull request Sep 15, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
eb41046 
…k@main

PR link: networkservicemesh/sdk#1511

Commit: d68a6f4
Author: Artem Glazychev
Date: 2023-09-15 16:22:24 +0700
Message:
  - [qfix] vl3mtu: store cloned conn (#1511)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Sep 15, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
a99bd53 
…k@main

PR link: networkservicemesh/sdk#1511

Commit: d68a6f4
Author: Artem Glazychev
Date: 2023-09-15 16:22:24 +0700
Message:
  - [qfix] vl3mtu: store cloned conn (#1511)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-csi-driver that referenced this pull request Sep 15, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
78db218 
…k@main

PR link: networkservicemesh/sdk#1511

Commit: d68a6f4
Author: Artem Glazychev
Date: 2023-09-15 16:22:24 +0700
Message:
  - [qfix] vl3mtu: store cloned conn (#1511)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Sep 15, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
c440d1c 
…k@main

PR link: networkservicemesh/sdk#1511

Commit: d68a6f4
Author: Artem Glazychev
Date: 2023-09-15 16:22:24 +0700
Message:
  - [qfix] vl3mtu: store cloned conn (#1511)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Sep 15, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
6eb0a0c 
…k@main

PR link: networkservicemesh/sdk#1511

Commit: d68a6f4
Author: Artem Glazychev
Date: 2023-09-15 16:22:24 +0700
Message:
  - [qfix] vl3mtu: store cloned conn (#1511)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Sep 15, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
13557a4 
…k@main

PR link: networkservicemesh/sdk#1511

Commit: d68a6f4
Author: Artem Glazychev
Date: 2023-09-15 16:22:24 +0700
Message:
  - [qfix] vl3mtu: store cloned conn (#1511)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request Sep 15, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
da06ef4 
…k@main

PR link: networkservicemesh/sdk#1511

Commit: d68a6f4
Author: Artem Glazychev
Date: 2023-09-15 16:22:24 +0700
Message:
  - [qfix] vl3mtu: store cloned conn (#1511)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Sep 15, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
f1db88f 
…k@main

PR link: networkservicemesh/sdk#1511

Commit: d68a6f4
Author: Artem Glazychev
Date: 2023-09-15 16:22:24 +0700
Message:
  - [qfix] vl3mtu: store cloned conn (#1511)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Sep 15, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
9168ec0 
…k@main

PR link: networkservicemesh/sdk#1511

Commit: d68a6f4
Author: Artem Glazychev
Date: 2023-09-15 16:22:24 +0700
Message:
  - [qfix] vl3mtu: store cloned conn (#1511)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Sep 15, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
0c62db8 
…k@main

PR link: networkservicemesh/sdk#1511

Commit: d68a6f4
Author: Artem Glazychev
Date: 2023-09-15 16:22:24 +0700
Message:
  - [qfix] vl3mtu: store cloned conn (#1511)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Sep 15, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Sep 15, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-tingaikin denis-tingaikin denis-tingaikin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glazychev-art @denis-tingaikin