-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(continuation) Enable logs from chain elements regardless of EnableTracing #1489
Merged
denis-tingaikin
merged 2 commits into
networkservicemesh:main
from
glazychev-art:log-level
Jul 13, 2023
Merged
(continuation) Enable logs from chain elements regardless of EnableTracing #1489
denis-tingaikin
merged 2 commits into
networkservicemesh:main
from
glazychev-art:log-level
Jul 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> always inject logger into context Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> fix copyright Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> fix race condition Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1489 +/- ##
=======================================
Coverage ? 70.35%
=======================================
Files ? 248
Lines ? 11201
Branches ? 0
=======================================
Hits ? 7880
Misses ? 2820
Partials ? 501 ☔ View full report in Codecov by Sentry. |
denis-tingaikin
approved these changes
Jul 13, 2023
nsmbot
pushed a commit
to networkservicemesh/cmd-csi-driver
that referenced
this pull request
Jul 13, 2023
…k@main PR link: networkservicemesh/sdk#1489 Commit: eaf1d25 Author: Artem Glazychev Date: 2023-07-13 15:43:22 +0700 Message: - (continuation) Enable logs from chain elements regardless of EnableTracing (#1489) * make IsTracingEnabled independent from log level Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> always inject logger into context Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> fix copyright Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> fix race condition Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * Add fixes for registry, dns Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Jul 13, 2023
…k@main PR link: networkservicemesh/sdk#1489 Commit: eaf1d25 Author: Artem Glazychev Date: 2023-07-13 15:43:22 +0700 Message: - (continuation) Enable logs from chain elements regardless of EnableTracing (#1489) * make IsTracingEnabled independent from log level Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> always inject logger into context Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> fix copyright Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> fix race condition Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * Add fixes for registry, dns Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-ipam-vl3
that referenced
this pull request
Jul 13, 2023
…k@main PR link: networkservicemesh/sdk#1489 Commit: eaf1d25 Author: Artem Glazychev Date: 2023-07-13 15:43:22 +0700 Message: - (continuation) Enable logs from chain elements regardless of EnableTracing (#1489) * make IsTracingEnabled independent from log level Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> always inject logger into context Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> fix copyright Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> fix race condition Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * Add fixes for registry, dns Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-admission-webhook-k8s
that referenced
this pull request
Jul 13, 2023
…k@main PR link: networkservicemesh/sdk#1489 Commit: eaf1d25 Author: Artem Glazychev Date: 2023-07-13 15:43:22 +0700 Message: - (continuation) Enable logs from chain elements regardless of EnableTracing (#1489) * make IsTracingEnabled independent from log level Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> always inject logger into context Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> fix copyright Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> fix race condition Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * Add fixes for registry, dns Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-cluster-info-k8s
that referenced
this pull request
Jul 13, 2023
…k@main PR link: networkservicemesh/sdk#1489 Commit: eaf1d25 Author: Artem Glazychev Date: 2023-07-13 15:43:22 +0700 Message: - (continuation) Enable logs from chain elements regardless of EnableTracing (#1489) * make IsTracingEnabled independent from log level Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> always inject logger into context Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> fix copyright Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> fix race condition Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * Add fixes for registry, dns Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-map-ip-k8s
that referenced
this pull request
Jul 13, 2023
…k@main PR link: networkservicemesh/sdk#1489 Commit: eaf1d25 Author: Artem Glazychev Date: 2023-07-13 15:43:22 +0700 Message: - (continuation) Enable logs from chain elements regardless of EnableTracing (#1489) * make IsTracingEnabled independent from log level Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> always inject logger into context Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> fix copyright Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> fix race condition Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * Add fixes for registry, dns Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Jul 13, 2023
…k@main PR link: networkservicemesh/sdk#1489 Commit: eaf1d25 Author: Artem Glazychev Date: 2023-07-13 15:43:22 +0700 Message: - (continuation) Enable logs from chain elements regardless of EnableTracing (#1489) * make IsTracingEnabled independent from log level Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> always inject logger into context Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> fix copyright Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> fix race condition Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * Add fixes for registry, dns Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Jul 13, 2023
…k@main PR link: networkservicemesh/sdk#1489 Commit: eaf1d25 Author: Artem Glazychev Date: 2023-07-13 15:43:22 +0700 Message: - (continuation) Enable logs from chain elements regardless of EnableTracing (#1489) * make IsTracingEnabled independent from log level Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> always inject logger into context Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> fix copyright Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> fix race condition Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * Add fixes for registry, dns Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Jul 13, 2023
…k@main PR link: networkservicemesh/sdk#1489 Commit: eaf1d25 Author: Artem Glazychev Date: 2023-07-13 15:43:22 +0700 Message: - (continuation) Enable logs from chain elements regardless of EnableTracing (#1489) * make IsTracingEnabled independent from log level Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> always inject logger into context Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> fix copyright Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> fix race condition Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * Add fixes for registry, dns Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-init
that referenced
this pull request
Jul 13, 2023
…k@main PR link: networkservicemesh/sdk#1489 Commit: eaf1d25 Author: Artem Glazychev Date: 2023-07-13 15:43:22 +0700 Message: - (continuation) Enable logs from chain elements regardless of EnableTracing (#1489) * make IsTracingEnabled independent from log level Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> always inject logger into context Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> fix copyright Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> fix race condition Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * Add fixes for registry, dns Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Jul 13, 2023
…k@main PR link: networkservicemesh/sdk#1489 Commit: eaf1d25 Author: Artem Glazychev Date: 2023-07-13 15:43:22 +0700 Message: - (continuation) Enable logs from chain elements regardless of EnableTracing (#1489) * make IsTracingEnabled independent from log level Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> always inject logger into context Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> fix copyright Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> fix race condition Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * Add fixes for registry, dns Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Jul 13, 2023
…k@main PR link: networkservicemesh/sdk#1489 Commit: eaf1d25 Author: Artem Glazychev Date: 2023-07-13 15:43:22 +0700 Message: - (continuation) Enable logs from chain elements regardless of EnableTracing (#1489) * make IsTracingEnabled independent from log level Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> always inject logger into context Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> fix copyright Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> fix race condition Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * Add fixes for registry, dns Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-remote-vlan
that referenced
this pull request
Jul 13, 2023
…k@main PR link: networkservicemesh/sdk#1489 Commit: eaf1d25 Author: Artem Glazychev Date: 2023-07-13 15:43:22 +0700 Message: - (continuation) Enable logs from chain elements regardless of EnableTracing (#1489) * make IsTracingEnabled independent from log level Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> always inject logger into context Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> fix copyright Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> fix race condition Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * Add fixes for registry, dns Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Jul 13, 2023
…k@main PR link: networkservicemesh/sdk#1489 Commit: eaf1d25 Author: Artem Glazychev Date: 2023-07-13 15:43:22 +0700 Message: - (continuation) Enable logs from chain elements regardless of EnableTracing (#1489) * make IsTracingEnabled independent from log level Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> always inject logger into context Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> fix copyright Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> fix race condition Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * Add fixes for registry, dns Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Jul 13, 2023
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Jul 18, 2023
…k@main PR link: networkservicemesh/sdk#1489 Commit: eaf1d25 Author: Artem Glazychev Date: 2023-07-13 15:43:22 +0700 Message: - (continuation) Enable logs from chain elements regardless of EnableTracing (#1489) * make IsTracingEnabled independent from log level Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> always inject logger into context Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> fix copyright Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> fix race condition Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * Add fixes for registry, dns Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Jul 18, 2023
…k@main PR link: networkservicemesh/sdk#1489 Commit: eaf1d25 Author: Artem Glazychev Date: 2023-07-13 15:43:22 +0700 Message: - (continuation) Enable logs from chain elements regardless of EnableTracing (#1489) * make IsTracingEnabled independent from log level Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> always inject logger into context Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> fix copyright Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> fix race condition Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * Add fixes for registry, dns Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-remote-vlan
that referenced
this pull request
Jul 18, 2023
…k@main PR link: networkservicemesh/sdk#1489 Commit: eaf1d25 Author: Artem Glazychev Date: 2023-07-13 15:43:22 +0700 Message: - (continuation) Enable logs from chain elements regardless of EnableTracing (#1489) * make IsTracingEnabled independent from log level Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> always inject logger into context Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> fix copyright Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> fix race condition Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> * Add fixes for registry, dns Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> --------- Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru> Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is continuation of - #1475
(see description there)
Example logs from forwarder with `DEBUG` log level
Issue link
Closes: #1475
networkservicemesh/deployments-k8s#9242
How Has This Been Tested?
Types of changes