Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qfix: Simplify forwarder selection #1452

Merged
merged 1 commit into from
May 1, 2023
Merged

qfix: Simplify forwarder selection #1452

merged 1 commit into from
May 1, 2023

Conversation

denis-tingaikin
Copy link
Member

Description

Closes networkservicemesh/integration-k8s-kind#813

Issue link

networkservicemesh/integration-k8s-kind#813

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionality
  • Documentation
  • Refactoring
  • CI

@denis-tingaikin
simplify forwarder selection and add test for remote death case
fde0584 
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@fbf0404). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1452   +/-   ##
=======================================
  Coverage        ?   70.25%           
=======================================
  Files           ?      242           
  Lines           ?    11014           
  Branches        ?        0           
=======================================
  Hits            ?     7738           
  Misses          ?     2778           
  Partials        ?      498

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@edwarnicke edwarnicke merged commit 6fa2f68 into main May 1, 2023
nsmbot pushed a commit to networkservicemesh/cmd-ipam-vl3 that referenced this pull request May 1, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
ca9392a 
…k@main

PR link: networkservicemesh/sdk#1452

Commit: 6fa2f68
Author: Denis Tingaikin
Date: 2023-05-01 03:52:04 +0300
Message:
  - simplify forwarder selection and add test for remote death case (#1452)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request May 1, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
64d3be7 
…k@main

PR link: networkservicemesh/sdk#1452

Commit: 6fa2f68
Author: Denis Tingaikin
Date: 2023-05-01 03:52:04 +0300
Message:
  - simplify forwarder selection and add test for remote death case (#1452)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request May 1, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
ca76fe6 
…k@main

PR link: networkservicemesh/sdk#1452

Commit: 6fa2f68
Author: Denis Tingaikin
Date: 2023-05-01 03:52:04 +0300
Message:
  - simplify forwarder selection and add test for remote death case (#1452)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this pull request May 1, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
1aff318 
…k@main

PR link: networkservicemesh/sdk#1452

Commit: 6fa2f68
Author: Denis Tingaikin
Date: 2023-05-01 03:52:04 +0300
Message:
  - simplify forwarder selection and add test for remote death case (#1452)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-cluster-info-k8s that referenced this pull request May 1, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
2322fac 
…k@main

PR link: networkservicemesh/sdk#1452

Commit: 6fa2f68
Author: Denis Tingaikin
Date: 2023-05-01 03:52:04 +0300
Message:
  - simplify forwarder selection and add test for remote death case (#1452)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request May 1, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
6cf77de 
…k@main

PR link: networkservicemesh/sdk#1452

Commit: 6fa2f68
Author: Denis Tingaikin
Date: 2023-05-01 03:52:04 +0300
Message:
  - simplify forwarder selection and add test for remote death case (#1452)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request May 1, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
d9a355d 
…k@main

PR link: networkservicemesh/sdk#1452

Commit: 6fa2f68
Author: Denis Tingaikin
Date: 2023-05-01 03:52:04 +0300
Message:
  - simplify forwarder selection and add test for remote death case (#1452)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request May 1, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
b51890d 
…k@main

PR link: networkservicemesh/sdk#1452

Commit: 6fa2f68
Author: Denis Tingaikin
Date: 2023-05-01 03:52:04 +0300
Message:
  - simplify forwarder selection and add test for remote death case (#1452)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request May 1, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
1a2fb93 
…k@main

PR link: networkservicemesh/sdk#1452

Commit: 6fa2f68
Author: Denis Tingaikin
Date: 2023-05-01 03:52:04 +0300
Message:
  - simplify forwarder selection and add test for remote death case (#1452)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request May 1, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
b12f233 
…k@main

PR link: networkservicemesh/sdk#1452

Commit: 6fa2f68
Author: Denis Tingaikin
Date: 2023-05-01 03:52:04 +0300
Message:
  - simplify forwarder selection and add test for remote death case (#1452)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request May 1, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
c108499 
…k@main

PR link: networkservicemesh/sdk#1452

Commit: 6fa2f68
Author: Denis Tingaikin
Date: 2023-05-01 03:52:04 +0300
Message:
  - simplify forwarder selection and add test for remote death case (#1452)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request May 1, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
e3697b0 
…k@main

PR link: networkservicemesh/sdk#1452

Commit: 6fa2f68
Author: Denis Tingaikin
Date: 2023-05-01 03:52:04 +0300
Message:
  - simplify forwarder selection and add test for remote death case (#1452)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request May 1, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
20fb4a4 
…k@main

PR link: networkservicemesh/sdk#1452

Commit: 6fa2f68
Author: Denis Tingaikin
Date: 2023-05-01 03:52:04 +0300
Message:
  - simplify forwarder selection and add test for remote death case (#1452)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced May 1, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request May 2, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
a5358fe 
…k@main

PR link: networkservicemesh/sdk#1452

Commit: 6fa2f68
Author: Denis Tingaikin
Date: 2023-05-01 03:52:04 +0300
Message:
  - simplify forwarder selection and add test for remote death case (#1452)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request May 2, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
3016bf1 
…k@main

PR link: networkservicemesh/sdk#1452

Commit: 6fa2f68
Author: Denis Tingaikin
Date: 2023-05-01 03:52:04 +0300
Message:
  - simplify forwarder selection and add test for remote death case (#1452)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced May 2, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwarnicke edwarnicke edwarnicke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@denis-tingaikin @edwarnicke