Return an error if there is no DNS address. #1424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
679e040 to
01c987a
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1424 +/- ##
=======================================
Coverage ? 70.15%
=======================================
Files ? 242
Lines ? 10956
Branches ? 0
=======================================
Hits ? 7686
Misses ? 2771
Partials ? 499 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
1fab66e to
0f49980
Compare
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
0f49980 to
cc16084
Compare
denis-tingaikin
approved these changes
Feb 20, 2023
nsmbot
pushed a commit
to networkservicemesh/cmd-cluster-info-k8s
that referenced
this pull request
Feb 20, 2023
…k@main PR link: networkservicemesh/sdk#1424 Commit: 26b7ec8 Author: Artem Glazychev Date: 2023-02-20 18:05:48 +0700 Message: - Return an error if there is no DNS address. (#1424) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-admission-webhook-k8s
that referenced
this pull request
Feb 20, 2023
…k@main PR link: networkservicemesh/sdk#1424 Commit: 26b7ec8 Author: Artem Glazychev Date: 2023-02-20 18:05:48 +0700 Message: - Return an error if there is no DNS address. (#1424) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-map-ip-k8s
that referenced
this pull request
Feb 20, 2023
…k@main PR link: networkservicemesh/sdk#1424 Commit: 26b7ec8 Author: Artem Glazychev Date: 2023-02-20 18:05:48 +0700 Message: - Return an error if there is no DNS address. (#1424) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-ipam-vl3
that referenced
this pull request
Feb 20, 2023
…k@main PR link: networkservicemesh/sdk#1424 Commit: 26b7ec8 Author: Artem Glazychev Date: 2023-02-20 18:05:48 +0700 Message: - Return an error if there is no DNS address. (#1424) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-init
that referenced
this pull request
Feb 20, 2023
…k@main PR link: networkservicemesh/sdk#1424 Commit: 26b7ec8 Author: Artem Glazychev Date: 2023-02-20 18:05:48 +0700 Message: - Return an error if there is no DNS address. (#1424) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-remote-vlan
that referenced
this pull request
Feb 20, 2023
…k@main PR link: networkservicemesh/sdk#1424 Commit: 26b7ec8 Author: Artem Glazychev Date: 2023-02-20 18:05:48 +0700 Message: - Return an error if there is no DNS address. (#1424) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Feb 20, 2023
…k@main PR link: networkservicemesh/sdk#1424 Commit: 26b7ec8 Author: Artem Glazychev Date: 2023-02-20 18:05:48 +0700 Message: - Return an error if there is no DNS address. (#1424) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Feb 20, 2023
…k@main PR link: networkservicemesh/sdk#1424 Commit: 26b7ec8 Author: Artem Glazychev Date: 2023-02-20 18:05:48 +0700 Message: - Return an error if there is no DNS address. (#1424) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Feb 20, 2023
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Feb 20, 2023
…k@main PR link: networkservicemesh/sdk#1424 Commit: 26b7ec8 Author: Artem Glazychev Date: 2023-02-20 18:05:48 +0700 Message: - Return an error if there is no DNS address. (#1424) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Feb 20, 2023
…k@main PR link: networkservicemesh/sdk#1424 Commit: 26b7ec8 Author: Artem Glazychev Date: 2023-02-20 18:05:48 +0700 Message: - Return an error if there is no DNS address. (#1424) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Feb 20, 2023
…k@main PR link: networkservicemesh/sdk#1424 Commit: 26b7ec8 Author: Artem Glazychev Date: 2023-02-20 18:05:48 +0700 Message: - Return an error if there is no DNS address. (#1424) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Feb 20, 2023
…k@main PR link: networkservicemesh/sdk#1424 Commit: 26b7ec8 Author: Artem Glazychev Date: 2023-02-20 18:05:48 +0700 Message: - Return an error if there is no DNS address. (#1424) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Feb 20, 2023
…k@main PR link: networkservicemesh/sdk#1424 Commit: 26b7ec8 Author: Artem Glazychev Date: 2023-02-20 18:05:48 +0700 Message: - Return an error if there is no DNS address. (#1424) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR partially reverts this - #1416
The previous approach using
monitorand sendingREFRESH_REQUESTEDevent is not suitable, since there is some time (even if very little) between theRequestandMonitorConnections. Because of this, we get into a situation where both theRequestand the event may not update the DNS context.In this PR we return an error until the address is assigned. But we must allow Request to itself, because that Request is what selects the addresses.
Issue link
networkservicemesh/integration-k8s-kind#750
How Has This Been Tested?
Types of changes