Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase DNS timeout #1346

Merged
merged 1 commit into from
Sep 8, 2022
Merged

Increase DNS timeout #1346

merged 1 commit into from
Sep 8, 2022

Conversation

glazychev-art
Copy link
Contributor

@glazychev-art glazychev-art commented Sep 7, 2022 •
edited
Loading

Signed-off-by: Artem Glazychev artem.glazychev@xored.com

Description

Main changes:

  1. Increase default dns timeout to 5 sec. It is linux default value - https://man7.org/linux/man-pages/man5/resolv.conf.5.html
  2. memory dns has to write something into the writer (even if the entry is not found)

Issue link

networkservicemesh/integration-k8s-packet#295

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionallity
  • Documentation
  • Refactoring
  • CI

@glazychev-art
Increase DNS timeout
a860259 
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
@denis-tingaikin denis-tingaikin merged commit aef323e into networkservicemesh:main Sep 8, 2022
nsmbot pushed a commit to networkservicemesh/cmd-cluster-info-k8s that referenced this pull request Sep 8, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
d7d16e8 
…k@main

PR link: networkservicemesh/sdk#1346

Commit: aef323e
Author: Artem Glazychev
Date: 2022-09-08 20:43:35 +0700
Message:
  - Increase DNS timeout (#1346)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Sep 8, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
897bca7 
…k@main

PR link: networkservicemesh/sdk#1346

Commit: aef323e
Author: Artem Glazychev
Date: 2022-09-08 20:43:35 +0700
Message:
  - Increase DNS timeout (#1346)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Sep 8, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
6eb7880 
…k@main

PR link: networkservicemesh/sdk#1346

Commit: aef323e
Author: Artem Glazychev
Date: 2022-09-08 20:43:35 +0700
Message:
  - Increase DNS timeout (#1346)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Sep 8, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
1095bdb 
…k@main

PR link: networkservicemesh/sdk#1346

Commit: aef323e
Author: Artem Glazychev
Date: 2022-09-08 20:43:35 +0700
Message:
  - Increase DNS timeout (#1346)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Sep 8, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
93879d8 
…k@main

PR link: networkservicemesh/sdk#1346

Commit: aef323e
Author: Artem Glazychev
Date: 2022-09-08 20:43:35 +0700
Message:
  - Increase DNS timeout (#1346)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-ipam-vl3 that referenced this pull request Sep 8, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
ff5dfbc 
…k@main

PR link: networkservicemesh/sdk#1346

Commit: aef323e
Author: Artem Glazychev
Date: 2022-09-08 20:43:35 +0700
Message:
  - Increase DNS timeout (#1346)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Sep 8, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
096764b 
…k@main

PR link: networkservicemesh/sdk#1346

Commit: aef323e
Author: Artem Glazychev
Date: 2022-09-08 20:43:35 +0700
Message:
  - Increase DNS timeout (#1346)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
@nsmbot nsmbot mentioned this pull request Sep 8, 2022
Merged
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Sep 8, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
241e97e 
…k@main

PR link: networkservicemesh/sdk#1346

Commit: aef323e
Author: Artem Glazychev
Date: 2022-09-08 20:43:35 +0700
Message:
  - Increase DNS timeout (#1346)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
@nsmbot nsmbot mentioned this pull request Sep 8, 2022
Merged
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Sep 8, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
40b6c22 
…k@main

PR link: networkservicemesh/sdk#1346

Commit: aef323e
Author: Artem Glazychev
Date: 2022-09-08 20:43:35 +0700
Message:
  - Increase DNS timeout (#1346)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
@nsmbot nsmbot mentioned this pull request Sep 8, 2022
Merged
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this pull request Sep 8, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
1798584 
…k@main

PR link: networkservicemesh/sdk#1346

Commit: aef323e
Author: Artem Glazychev
Date: 2022-09-08 20:43:35 +0700
Message:
  - Increase DNS timeout (#1346)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Sep 8, 2022
Merged
Merged
Merged
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request Sep 8, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
558ac5c 
…k@main

PR link: networkservicemesh/sdk#1346

Commit: aef323e
Author: Artem Glazychev
Date: 2022-09-08 20:43:35 +0700
Message:
  - Increase DNS timeout (#1346)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Sep 8, 2022
Merged
Merged
Merged
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Sep 8, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
9c6cf55 
…k@main

PR link: networkservicemesh/sdk#1346

Commit: aef323e
Author: Artem Glazychev
Date: 2022-09-08 20:43:35 +0700
Message:
  - Increase DNS timeout (#1346)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Sep 8, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-tingaikin denis-tingaikin denis-tingaikin approved these changes

@NikitaSkrynnik NikitaSkrynnik Awaiting requested review from NikitaSkrynnik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glazychev-art @denis-tingaikin