Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix upstream notifier #1327

Merged
merged 1 commit into from
Jul 18, 2022
Merged

Fix upstream notifier #1327

merged 1 commit into from
Jul 18, 2022

Conversation

glazychev-art
Copy link
Contributor

@glazychev-art glazychev-art commented Jul 15, 2022 •
edited
Loading

Signed-off-by: Artem Glazychev artem.glazychev@xored.com

Description

This PR solves 2 main problems:

  1. We can't use sync.Map for notifier, because sync.Map Range is not thread safe:
// Range does not necessarily correspond to any consistent snapshot of the Map's
// contents: no key will be visited more than once, but if the value for any key
// is stored or deleted concurrently (including by f), Range may reflect any
// mapping for that key from any point during the Range call. Range does not
// block other methods on the receiver; even f itself may call any method on m.

It was changed to executor.

  1. Found another case when we need to send a local notification:

Screenshot from 2022-07-15 19-05-28

For example, vl3-NSE1 first establishes a connection with vl3-NSE2 and uses MTU:9000. After that, it connects with vl3-NSE3, MTU:1440. How do we trigger the connection conn1-2 ? We can send the notification from the vl3-client if MTU value has changed.

  1. Added a couple of unit tests to cover upstreamrefresh

Issue link

networkservicemesh/cmd-nse-vl3-vpp#77

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionallity
  • Documentation
  • Refactoring
  • CI

@glazychev-art
Fix upstream notifier
74d7e78 
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
@glazychev-art glazychev-art marked this pull request as ready for review July 15, 2022 12:46
@glazychev-art glazychev-art mentioned this pull request Jul 15, 2022
Merged
@denis-tingaikin denis-tingaikin merged commit dc978c4 into networkservicemesh:main Jul 18, 2022
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Jul 18, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
2fbeef5 
…k@main

PR link: networkservicemesh/sdk#1327

Commit: dc978c4
Author: Artem Glazychev
Date: 2022-07-19 00:14:14 +0700
Message:
  - Fix upstream notifier (#1327)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request Jul 18, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
2578910 
…k@main

PR link: networkservicemesh/sdk#1327

Commit: dc978c4
Author: Artem Glazychev
Date: 2022-07-19 00:14:14 +0700
Message:
  - Fix upstream notifier (#1327)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-ipam-vl3 that referenced this pull request Jul 18, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
e4de24a 
…k@main

PR link: networkservicemesh/sdk#1327

Commit: dc978c4
Author: Artem Glazychev
Date: 2022-07-19 00:14:14 +0700
Message:
  - Fix upstream notifier (#1327)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Jul 18, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
a9475ed 
…k@main

PR link: networkservicemesh/sdk#1327

Commit: dc978c4
Author: Artem Glazychev
Date: 2022-07-19 00:14:14 +0700
Message:
  - Fix upstream notifier (#1327)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this pull request Jul 18, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
fc00fec 
…k@main

PR link: networkservicemesh/sdk#1327

Commit: dc978c4
Author: Artem Glazychev
Date: 2022-07-19 00:14:14 +0700
Message:
  - Fix upstream notifier (#1327)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Jul 18, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
fe0811a 
…k@main

PR link: networkservicemesh/sdk#1327

Commit: dc978c4
Author: Artem Glazychev
Date: 2022-07-19 00:14:14 +0700
Message:
  - Fix upstream notifier (#1327)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Jul 18, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
fa5d19c 
…k@main

PR link: networkservicemesh/sdk#1327

Commit: dc978c4
Author: Artem Glazychev
Date: 2022-07-19 00:14:14 +0700
Message:
  - Fix upstream notifier (#1327)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Jul 18, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
dbca375 
…k@main

PR link: networkservicemesh/sdk#1327

Commit: dc978c4
Author: Artem Glazychev
Date: 2022-07-19 00:14:14 +0700
Message:
  - Fix upstream notifier (#1327)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Jul 18, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
82c8205 
…k@main

PR link: networkservicemesh/sdk#1327

Commit: dc978c4
Author: Artem Glazychev
Date: 2022-07-19 00:14:14 +0700
Message:
  - Fix upstream notifier (#1327)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Jul 18, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
2c0679a 
…k@main

PR link: networkservicemesh/sdk#1327

Commit: dc978c4
Author: Artem Glazychev
Date: 2022-07-19 00:14:14 +0700
Message:
  - Fix upstream notifier (#1327)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Jul 18, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
3b80119 
…k@main

PR link: networkservicemesh/sdk#1327

Commit: dc978c4
Author: Artem Glazychev
Date: 2022-07-19 00:14:14 +0700
Message:
  - Fix upstream notifier (#1327)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Jul 18, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
709ad84 
…k@main

PR link: networkservicemesh/sdk#1327

Commit: dc978c4
Author: Artem Glazychev
Date: 2022-07-19 00:14:14 +0700
Message:
  - Fix upstream notifier (#1327)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Jul 18, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@nsmbot nsmbot mentioned this pull request Jul 19, 2022
Merged
anastasia-malysheva pushed a commit to anastasia-malysheva/sdk that referenced this pull request Jul 27, 2022
@glazychev-art @anastasia-malysheva
Fix upstream notifier (networkservicemesh#1327)
34b2302 
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-tingaikin denis-tingaikin denis-tingaikin approved these changes

@edwarnicke edwarnicke Awaiting requested review from edwarnicke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glazychev-art @denis-tingaikin