Simplify NSM logging system #1308
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>
b07d7e9 to
ebf273b
Compare
Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>
Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>
NikitaSkrynnik
approved these changes
Jun 15, 2022
pkg/registry/core/trace/common.go
Outdated
| } else { | ||
| msg = fmt.Sprint(v) | ||
| registryInfo, ok := trace(ctx) | ||
| if ok && registryInfo.Request != nil { |
There was a problem hiding this comment.
This condition is always false
We don't need to check Request and Response, because these fields are used only for networkservice (not for registry)
There was a problem hiding this comment.
@glazychev-art , fixes for both comments were made
pkg/registry/core/trace/context.go
Outdated
| ) | ||
|
|
||
| // traceInfo - struct, containing string representations of request and response, used for tracing. |
There was a problem hiding this comment.
Suggested change
| // traceInfo - struct, containing string representations of request and response, used for tracing. | |
| type traceInfo struct {} |
Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>
Signed-off-by: anastasia.malysheva <anastasia.malysheva@xored.com>
|
@glazychev-art Is this ready to merge? |
glazychev-art
approved these changes
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
EnableTracing was removed. Instead LogLevel is used to enable tracing if TraceLevel is set.
Issue link
#1272
How Has This Been Tested?
Types of changes