Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use max of ctx.deadline and requestDuration for healing #1006

Merged

Conversation

glazychev-art
Copy link
Contributor

@glazychev-art glazychev-art commented Jul 6, 2021

Signed-off-by: Artem Glazychev artem.glazychev@xored.com

Description

Current request duration in not enough for healing.

Issue link

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionallity
  • Documentation
  • Refactoring
  • CI

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
@glazychev-art glazychev-art marked this pull request as ready for review July 6, 2021 08:10
@denis-tingaikin
Copy link
Member

This should fix networkservicemesh/integration-k8s-kind#307

So merging.

@denis-tingaikin denis-tingaikin merged commit d4734b5 into networkservicemesh:main Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants