Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated API for watching VPPAPI events #798

Merged
merged 6 commits into from
Feb 20, 2024
Merged

Remove deprecated API for watching VPPAPI events #798

merged 6 commits into from
Feb 20, 2024

Conversation

NikitaSkrynnik
Copy link
Contributor

@glazychev-art
Copy link
Contributor

I guess we should use the same approach for https://github.com/networkservicemesh/sdk-vpp/blob/main/pkg/networkservice/up/common.go

@NikitaSkrynnik NikitaSkrynnik force-pushed the watcher branch 4 times, most recently from 58ae48d to 180c534 Compare February 5, 2024 08:53
@NikitaSkrynnik NikitaSkrynnik self-assigned this Feb 5, 2024
@NikitaSkrynnik NikitaSkrynnik force-pushed the watcher branch 2 times, most recently from a873907 to c72e8a2 Compare February 5, 2024 09:00
@NikitaSkrynnik NikitaSkrynnik force-pushed the watcher branch 2 times, most recently from 77e36ef to efa502d Compare February 12, 2024 09:16
glazychev-art
glazychev-art approved these changes Feb 20, 2024
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@NikitaSkrynnik
add watcher
8246fe6 
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
@NikitaSkrynnik
remove deprecated API from wireguard
7ff6066 
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
@NikitaSkrynnik
fix golangci linter
e32b5e2 
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
@NikitaSkrynnik
go mod tidy
c3992a4 
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
@NikitaSkrynnik
delete more of deprecated API
3b1187a 
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
@NikitaSkrynnik
fix go linter issues
fed9bea 
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
@denis-tingaikin denis-tingaikin merged commit e132a82 into networkservicemesh:main Feb 20, 2024
13 checks passed
nsmbot pushed a commit to networkservicemesh/cmd-lb-vl3-vpp that referenced this pull request Feb 20, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
3bf8103 
…k-vpp@main

PR link: networkservicemesh/sdk-vpp#798

Commit: e132a82
Author: Nikita Skrynnik
Date: 2024-02-20 16:42:18 +0700
Message:
  - Remove deprecated API for watching VPPAPI events (#798)
* add watcher

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* remove deprecated API from wireguard

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix golangci linter

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* go mod tidy

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* delete more of deprecated API

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix go linter issues

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

---------

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-simple-vl3-docker that referenced this pull request Feb 20, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
bcee401 
…k-vpp@main

PR link: networkservicemesh/sdk-vpp#798

Commit: e132a82
Author: Nikita Skrynnik
Date: 2024-02-20 16:42:18 +0700
Message:
  - Remove deprecated API for watching VPPAPI events (#798)
* add watcher

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* remove deprecated API from wireguard

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix golangci linter

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* go mod tidy

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* delete more of deprecated API

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix go linter issues

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

---------

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vl3-vpp that referenced this pull request Feb 20, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
444a4e5 
…k-vpp@main

PR link: networkservicemesh/sdk-vpp#798

Commit: e132a82
Author: Nikita Skrynnik
Date: 2024-02-20 16:42:18 +0700
Message:
  - Remove deprecated API for watching VPPAPI events (#798)
* add watcher

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* remove deprecated API from wireguard

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix golangci linter

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* go mod tidy

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* delete more of deprecated API

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix go linter issues

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

---------

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-simple-docker that referenced this pull request Feb 20, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
9ea956f 
…k-vpp@main

PR link: networkservicemesh/sdk-vpp#798

Commit: e132a82
Author: Nikita Skrynnik
Date: 2024-02-20 16:42:18 +0700
Message:
  - Remove deprecated API for watching VPPAPI events (#798)
* add watcher

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* remove deprecated API from wireguard

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix golangci linter

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* go mod tidy

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* delete more of deprecated API

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix go linter issues

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

---------

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-icmp-responder-vpp that referenced this pull request Feb 20, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
89ce680 
…k-vpp@main

PR link: networkservicemesh/sdk-vpp#798

Commit: e132a82
Author: Nikita Skrynnik
Date: 2024-02-20 16:42:18 +0700
Message:
  - Remove deprecated API for watching VPPAPI events (#798)
* add watcher

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* remove deprecated API from wireguard

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix golangci linter

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* go mod tidy

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* delete more of deprecated API

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix go linter issues

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

---------

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-firewall-vpp that referenced this pull request Feb 20, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
a6ea91a 
…k-vpp@main

PR link: networkservicemesh/sdk-vpp#798

Commit: e132a82
Author: Nikita Skrynnik
Date: 2024-02-20 16:42:18 +0700
Message:
  - Remove deprecated API for watching VPPAPI events (#798)
* add watcher

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* remove deprecated API from wireguard

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix golangci linter

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* go mod tidy

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* delete more of deprecated API

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix go linter issues

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

---------

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-vpp that referenced this pull request Feb 20, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
02a53b6 
…k-vpp@main

PR link: networkservicemesh/sdk-vpp#798

Commit: e132a82
Author: Nikita Skrynnik
Date: 2024-02-20 16:42:18 +0700
Message:
  - Remove deprecated API for watching VPPAPI events (#798)
* add watcher

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* remove deprecated API from wireguard

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix golangci linter

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* go mod tidy

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* delete more of deprecated API

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix go linter issues

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

---------

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-forwarder-vpp that referenced this pull request Feb 20, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
86881cb 
…k-vpp@main

PR link: networkservicemesh/sdk-vpp#798

Commit: e132a82
Author: Nikita Skrynnik
Date: 2024-02-20 16:42:18 +0700
Message:
  - Remove deprecated API for watching VPPAPI events (#798)
* add watcher

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* remove deprecated API from wireguard

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix golangci linter

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* go mod tidy

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* delete more of deprecated API

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix go linter issues

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

---------

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vlan-vpp that referenced this pull request Feb 20, 2024
Update go.mod and go.sum to latest version from networkservicemesh/sd…
5958de2 
…k-vpp@main

PR link: networkservicemesh/sdk-vpp#798

Commit: e132a82
Author: Nikita Skrynnik
Date: 2024-02-20 16:42:18 +0700
Message:
  - Remove deprecated API for watching VPPAPI events (#798)
* add watcher

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* remove deprecated API from wireguard

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix golangci linter

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* go mod tidy

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* delete more of deprecated API

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix go linter issues

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

---------

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Feb 20, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
NikitaSkrynnik added a commit to NikitaSkrynnik/sdk-vpp that referenced this pull request Feb 29, 2024
@NikitaSkrynnik
Remove deprecated API for watching VPPAPI events (networkservicemesh#798
4e554ca 
)

* add watcher

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* remove deprecated API from wireguard

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix golangci linter

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* go mod tidy

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* delete more of deprecated API

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix go linter issues

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

---------

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
NikitaSkrynnik added a commit to NikitaSkrynnik/sdk-vpp that referenced this pull request Mar 1, 2024
@NikitaSkrynnik
Remove deprecated API for watching VPPAPI events (networkservicemesh#798
6d1beb1 
)

* add watcher

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* remove deprecated API from wireguard

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix golangci linter

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* go mod tidy

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* delete more of deprecated API

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix go linter issues

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

---------

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
denis-tingaikin pushed a commit that referenced this pull request Mar 6, 2024
@NikitaSkrynnik
Pass interface index to VPP ping API (#800)
c7e7e23 
* Remove deprecated API for watching VPPAPI events (#798)

* add watcher

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* remove deprecated API from wireguard

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* fix golangci linter

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* go mod tidy

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

* delete more of deprecated API

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix go linter issues

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

---------

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

* fix go linter issues

Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>

---------

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NikitaSkrynnik <nikita.skrynnik@xored.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-tingaikin denis-tingaikin denis-tingaikin approved these changes

@glazychev-art glazychev-art glazychev-art approved these changes

Assignees

@NikitaSkrynnik NikitaSkrynnik

Labels
None yet
Projects
Release v1.13.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NikitaSkrynnik @glazychev-art @denis-tingaikin