pinhole: fix behavior in case of creation error #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
denis-tingaikin
approved these changes
Oct 24, 2023
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-vpp
that referenced
this pull request
Oct 24, 2023
…k-vpp@main PR link: networkservicemesh/sdk-vpp#762 Commit: af5c232 Author: Artem Glazychev Date: 2023-10-24 17:10:56 +0700 Message: - pinhole: fix behavior in case of creation error (#762) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-simple-docker
that referenced
this pull request
Oct 24, 2023
…k-vpp@main PR link: networkservicemesh/sdk-vpp#762 Commit: af5c232 Author: Artem Glazychev Date: 2023-10-24 17:10:56 +0700 Message: - pinhole: fix behavior in case of creation error (#762) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vl3-vpp
that referenced
this pull request
Oct 24, 2023
…k-vpp@main PR link: networkservicemesh/sdk-vpp#762 Commit: af5c232 Author: Artem Glazychev Date: 2023-10-24 17:10:56 +0700 Message: - pinhole: fix behavior in case of creation error (#762) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-firewall-vpp
that referenced
this pull request
Oct 24, 2023
…k-vpp@main PR link: networkservicemesh/sdk-vpp#762 Commit: af5c232 Author: Artem Glazychev Date: 2023-10-24 17:10:56 +0700 Message: - pinhole: fix behavior in case of creation error (#762) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-forwarder-vpp
that referenced
this pull request
Oct 24, 2023
…k-vpp@main PR link: networkservicemesh/sdk-vpp#762 Commit: af5c232 Author: Artem Glazychev Date: 2023-10-24 17:10:56 +0700 Message: - pinhole: fix behavior in case of creation error (#762) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-lb-vl3-vpp
that referenced
this pull request
Oct 24, 2023
…k-vpp@main PR link: networkservicemesh/sdk-vpp#762 Commit: af5c232 Author: Artem Glazychev Date: 2023-10-24 17:10:56 +0700 Message: - pinhole: fix behavior in case of creation error (#762) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-icmp-responder-vpp
that referenced
this pull request
Oct 24, 2023
…k-vpp@main PR link: networkservicemesh/sdk-vpp#762 Commit: af5c232 Author: Artem Glazychev Date: 2023-10-24 17:10:56 +0700 Message: - pinhole: fix behavior in case of creation error (#762) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-simple-vl3-docker
that referenced
this pull request
Oct 24, 2023
…k-vpp@main PR link: networkservicemesh/sdk-vpp#762 Commit: af5c232 Author: Artem Glazychev Date: 2023-10-24 17:10:56 +0700 Message: - pinhole: fix behavior in case of creation error (#762) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vlan-vpp
that referenced
this pull request
Oct 24, 2023
…k-vpp@main PR link: networkservicemesh/sdk-vpp#762 Commit: af5c232 Author: Artem Glazychev Date: 2023-10-24 17:10:56 +0700 Message: - pinhole: fix behavior in case of creation error (#762) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Oct 24, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: networkservicemesh/cmd-forwarder-vpp#927
Previously, we used
ipPortMap.LoadOrStore()before creation. But if thecreatefunction returned an error, then the behavior is incorrect, since we already saved the value in the map.