Fix for metadata leak #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>
Bolodya1997
reviewed
Oct 14, 2021
| @@ -87,5 +88,8 @@ func (i *ipaddressClient) Request(ctx context.Context, request *networkservice.N | |||
| } | |||
|
|
|||
| func (i *ipaddressClient) Close(ctx context.Context, conn *networkservice.Connection, opts ...grpc.CallOption) (*empty.Empty, error) { | |||
| if err := addDel(ctx, conn, i.vppConn, metadata.IsClient(i), false); err != nil { | |||
| log.FromContext(ctx).Error(err) | |||
There was a problem hiding this comment.
I suppose that it is Warn, not Error, because nothing is actually failing.
There was a problem hiding this comment.
@Mixaster995
please, use for ipaddressServer the same logic
There was a problem hiding this comment.
@glazychev-art ok, done
|
Have you checked all chain elements that use metadata? And if they call |
|
@glazychev-art i rechecked again and now it should be all components that lacked metadata cleanup |
Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>
970e34b to
2d979e3
Compare
denis-tingaikin
approved these changes
Oct 14, 2021
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-icmp-responder-vpp
that referenced
this pull request
Oct 14, 2021
…k-vpp@main PR link: networkservicemesh/sdk-vpp#412 Commit: 2f5f7f7 Author: Авраменко Михаил Date: 2021-10-14 16:23:56 +0700 Message: - Fix for metadata leak (#412) * removed possible metadata leak Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com> * added metadata cleanup for few more components Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-vpp
that referenced
this pull request
Oct 14, 2021
…k-vpp@main PR link: networkservicemesh/sdk-vpp#412 Commit: 2f5f7f7 Author: Авраменко Михаил Date: 2021-10-14 16:23:56 +0700 Message: - Fix for metadata leak (#412) * removed possible metadata leak Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com> * added metadata cleanup for few more components Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-firewall-vpp
that referenced
this pull request
Oct 14, 2021
…k-vpp@main PR link: networkservicemesh/sdk-vpp#412 Commit: 2f5f7f7 Author: Авраменко Михаил Date: 2021-10-14 16:23:56 +0700 Message: - Fix for metadata leak (#412) * removed possible metadata leak Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com> * added metadata cleanup for few more components Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Oct 14, 2021
Merged
nsmbot
pushed a commit
that referenced
this pull request
Jan 24, 2022
…k-kernel@main PR link: networkservicemesh/sdk-kernel#412 Commit: 500ed31 Author: Ed Warnicke Date: 2022-01-24 10:21:34 -0600 Message: - Merge pull request #412 from Nordix/411 Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
denis-tingaikin
pushed a commit
that referenced
this pull request
Jan 25, 2022
* Update go.mod and go.sum to latest version from networkservicemesh/sdk-kernel@main PR link: networkservicemesh/sdk-kernel#412 Commit: 500ed31 Author: Ed Warnicke Date: 2022-01-24 10:21:34 -0600 Message: - Merge pull request #412 from Nordix/411 Signed-off-by: NSMBot <nsmbot@networkservicmesh.io> * Fix after netlink update Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Co-authored-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mikhail Avramenko avramenkomihail15@gmail.com
Description
Removed possible metadata memory leak
Issue
part of networkservicemesh/sdk#1101