Fix interface cleanup #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2825ece to
93270f9
Compare
Move an orphan nsm interface to host namespace and delete it. Related issue: networkservicemesh/deployments-k8s#9778 Signed-off-by: Laszlo Kiraly <laszlo.kiraly@est.tech>
|
Also changed call order as @glazychev-art suggested in networkservicemesh/sdk-ovs#275 (comment) |
9 tasks
glazychev-art
approved these changes
Nov 9, 2023
denis-tingaikin
approved these changes
Nov 10, 2023
|
@denis-tingaikin I verified manually running Kernel2Kernel, Kernel2IP2Kernel, feature tests and local_forwarder_death, remote_forwarder_death healing tests with forwarder-ovs. I did not verified forwarder-sriov. That might be affected by these changes. |
|
@ljkiraly OK, perfect. We're planning to release v1.11.1-RC.2 on Monday. Are these fixes urgent for you? Can we merge this PR right after v1.11.1? |
|
@denis-tingaikin Not so urgent, can wait after release. |
denis-tingaikin
approved these changes
Nov 21, 2023
nsmbot
pushed a commit
to networkservicemesh/sdk-sriov
that referenced
this pull request
Nov 21, 2023
…k-kernel@main PR link: networkservicemesh/sdk-kernel#618 Commit: 97e3e21 Author: Denis Tingaikin Date: 2023-11-21 18:18:35 +0300 Message: - Merge pull request #618 from Nordix/ovs-cleanup Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-l7-proxy
that referenced
this pull request
Nov 21, 2023
…k-kernel@main PR link: networkservicemesh/sdk-kernel#618 Commit: 97e3e21 Author: Denis Tingaikin Date: 2023-11-21 18:18:35 +0300 Message: - Merge pull request #618 from Nordix/ovs-cleanup Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-vpp
that referenced
this pull request
Nov 21, 2023
…k-kernel@main PR link: networkservicemesh/sdk-kernel#618 Commit: 97e3e21 Author: Denis Tingaikin Date: 2023-11-21 18:18:35 +0300 Message: - Merge pull request #618 from Nordix/ovs-cleanup Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move any orphan nsm interface to host namespace and delete it.
Related issue: networkservicemesh/deployments-k8s#9778