fixed error when using get with empty namespace #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>
| if err == nil { | ||
| exist.Spec = *(*v1.NetworkServiceEndpointSpec)(request) |
There was a problem hiding this comment.
Why is this line removed?
| if err == nil { | ||
| exist.Spec = *(*v1.NetworkServiceSpec)(request) |
There was a problem hiding this comment.
Why is this line removed?
Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>
nsmbot
pushed a commit
to networkservicemesh/cmd-forwarder-sriov
that referenced
this pull request
Oct 12, 2021
…k-k8s@main PR link: networkservicemesh/sdk-k8s#255 Commit: 10c8425 Author: Denis Tingaikin Date: 2021-10-12 14:57:37 +0300 Message: - Merge pull request #255 from Mixaster995/bug/empty-ns-error Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-k8s
that referenced
this pull request
Oct 12, 2021
…k-k8s@main PR link: networkservicemesh/sdk-k8s#255 Commit: 10c8425 Author: Denis Tingaikin Date: 2021-10-12 14:57:37 +0300 Message: - Merge pull request #255 from Mixaster995/bug/empty-ns-error Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-supplier-k8s
that referenced
this pull request
Oct 12, 2021
…k-k8s@main PR link: networkservicemesh/sdk-k8s#255 Commit: 10c8425 Author: Denis Tingaikin Date: 2021-10-12 14:57:37 +0300 Message: - Merge pull request #255 from Mixaster995/bug/empty-ns-error Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mikhail Avramenko avramenkomihail15@gmail.com
Description
k8s api rest methods not working properly with empty namespaces, so changed get to list
Issue
part of #252