Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New govpp tagging. #28

Merged
merged 3 commits into from
Mar 28, 2024
Merged

New govpp tagging. #28

merged 3 commits into from
Mar 28, 2024

Conversation

VitalyGushin
Copy link
Collaborator

@VitalyGushin VitalyGushin commented Feb 28, 2024

#18

@glazychev-art
Copy link

I'm not sure that we need to use a separate Release workflow file. Because govpp is not a typical cmd-* repository. It has a special way of building.
Main differences:

  • we are running a special powerful server to build this image. (see name: Setup actions runner from ci.yaml). Simple github servers cannot do this.
  • Docker image build uses certain flags (--target vpp).
  • we don't need to update deployments-k8s because deployments-k8s doesn't use govpp directly. Instead we update cmd-* repositories (see update-dependent-repositories.yaml).

I would suggest modifying ci.yaml and update-dependent-repositories.yaml to make a release.

Signed-off-by: Vitaliy Guschin <vitaliy.guschin@spirent.com>
@glazychev-art
Copy link

I still think we need changes in update-dependent-repositories.yaml
For example:

go get -u github.com/${{ github.repository }}@${{ github.sha }}

=>
go get -u github.com/${{ github.repository }}@${{ inputs.docker_tag }}

or cosmetic

echo "Update go.mod and go.sum to latest version from ${{ github.repository }}@main" >> /tmp/commit-message

=>
...from ${{ github.repository }}@${{ inputs.docker_tag }}
What do you think?

Vitaliy Guschin added 2 commits March 27, 2024 17:55
Signed-off-by: Vitaliy Guschin <vitaliy.guschin@spirent.com>
Signed-off-by: Vitaliy Guschin <vitaliy.guschin@spirent.com>
@VitalyGushin
Copy link
Collaborator Author

@glazychev-art I think the behaviour won't change essentially, but it might be more informative. Fixed.

@denis-tingaikin denis-tingaikin merged commit 8a44468 into main Mar 28, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants