Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scale-from-zero example #1372

Merged
merged 15 commits into from
May 27, 2021
Merged

Add scale-from-zero example #1372

merged 15 commits into from
May 27, 2021

Conversation

d-uzlov
Copy link
Contributor

@d-uzlov d-uzlov commented May 20, 2021

Fixes #1328

@d-uzlov d-uzlov marked this pull request as ready for review May 26, 2021 04:30
Copy link
Member

@denis-tingaikin denis-tingaikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, added few comments

examples/features/scale-from-zero/README.md Outdated Show resolved Hide resolved
examples/features/scale-from-zero/supplier-role.yaml Outdated Show resolved Hide resolved
Copy link
Member

@denis-tingaikin denis-tingaikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, added few comments

examples/features/scale-from-zero/README.md Outdated Show resolved Hide resolved
Copy link
Member

@denis-tingaikin denis-tingaikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added few comments to make the example clear for folks :)

examples/features/scale-from-zero/README.md Outdated Show resolved Hide resolved
examples/features/scale-from-zero/README.md Outdated Show resolved Hide resolved

Wait for applications ready:
```bash
kubectl wait --for=condition=ready --timeout=1m pod -l app=nse-icmp-responder -n ${NAMESPACE}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to wait?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a fresh cluster start of the pods can time quite long time. If we don't wait, subsequent commands will fail.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have a prefetch for this. This should not affect the test.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the other tests have wait till pods are ready. Are you sure it's safe to remove the wait?
Also, if someone replicates this example manually, they will have to wait manually until all the images are downloaded.

This wait doesn't increase duration of the test. If we already have everything in the cache, and pods started immediately, kubectl wait --for=condition=ready will return without any delay.

examples/features/scale-from-zero/README.md Outdated Show resolved Hide resolved
examples/features/scale-from-zero/README.md Outdated Show resolved Hide resolved
examples/features/scale-from-zero/README.md Outdated Show resolved Hide resolved
examples/features/scale-from-zero/README.md Outdated Show resolved Hide resolved
Comment on lines 52 to 143
Wait for applications ready:
```bash
kubectl wait --for=condition=ready --timeout=1m pod -l app=nse-icmp-responder -n ${NAMESPACE}
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Wait for applications ready:
```bash
kubectl wait --for=condition=ready --timeout=1m pod -l app=nse-icmp-responder -n ${NAMESPACE}
```

examples/features/scale-from-zero/README.md Outdated Show resolved Hide resolved
examples/features/scale-from-zero/README.md Outdated Show resolved Hide resolved
d-uzlov and others added 15 commits May 27, 2021 16:49
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
@denis-tingaikin denis-tingaikin merged commit de09285 into networkservicemesh:main May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add topology aware scale-from-zero running of NSEs in response to NSC demand example
2 participants