Add volumeClaimTemplates to the spire-server statefulset #10287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@szvincze |
szvincze
approved these changes
Nov 9, 2023
There was a problem hiding this comment.
Looks good to me.
With this change we don't need to restart spire-agents at the end of this test anymore:
https://github.com/networkservicemesh/deployments-k8s/blob/main/examples/heal/spire-server-restart/README.md
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
70de080 to
b83ee8d
Compare
Thanks! Fixed |
denis-tingaikin
approved these changes
Nov 28, 2023
denis-tingaikin
approved these changes
Dec 18, 2023
nsmbot
pushed a commit
to networkservicemesh/integration-tests
that referenced
this pull request
Dec 18, 2023
…ployments-k8s@main PR link: networkservicemesh/deployments-k8s#10287 Commit: ddcfbad Author: Network Service Mesh Bot Date: 2023-12-18 02:49:16 -0600 Message: - Update go.mod and go.sum to latest version from networkservicemesh/de… Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Spire-server requires
PersistentVolumefor/run/spire/data.Apparently, if the server is restarted, this data is used to issue the correct certificates.
If we don't use the PersistentVolume, then new and old certificates are not compatible with each other.
See manuals:
Example:
https://github.com/spiffe/spire-tutorials/blob/main/k8s/quickstart/server-statefulset.yaml#L54-L63
Issue link
#10286
How Has This Been Tested?
Types of changes