Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MTU property as parameter of the Service #107

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add MTU property as parameter of the Service #107

wants to merge 1 commit into from

Conversation

LionelJouin
Copy link
Member

@LionelJouin LionelJouin commented Oct 24, 2022 •
edited
Loading

Makes the MTU configurable in addition to the vlan ID and the base interface.

Changes in the SDK-VPP is needed to support this change since the vlan-mtu chain element will overwrite the MTU if the MTU of the base interface is lower than the requested one. Currently the base interface always has 0 as MTU.
https://github.com/networkservicemesh/sdk-vpp/blob/main/pkg/networkservice/mechanisms/vlan/mtu/client.go#L74

              Name               Idx    State  MTU (L3/IP4/IP6/MPLS)     Counter          Count     
host-eth0                         1      up     1500/1500/1500/1500 rx packets                 66576
                                                                    rx bytes               143097142
                                                                    tx packets                  2374
                                                                    tx bytes                  199928
                                                                    drops                      64198
                                                                    ip4                        30401
                                                                    ip6                            1
host-eth0.100                     2      up           0/0/0/0       rx packets                  2363
                                                                    rx bytes                  197399
                                                                    tx packets                  2356
                                                                    tx bytes                  196880

@LionelJouin LionelJouin mentioned this pull request Oct 24, 2022
Draft
10 tasks
@LionelJouin LionelJouin requested a review from ljkiraly October 25, 2022 08:46
@LionelJouin
Add MTU property as parameter of the Service
b393c4b 
Makes the MTU configurable in addition to the vlan ID and the base
interface.

Signed-off-by: Lionel Jouin <lionel.jouin@est.tech>
ljkiraly added a commit to Nordix/nsm-sdk-vpp that referenced this pull request Nov 10, 2022
@ljkiraly
Fix MTU adjustment in case of remote vlan mechanism
e3b851e 
The MTU should be updated in connection context based on the host
interface MTU in vpp instead of the sub-interface MTU.

Related PR: networkservicemesh/cmd-nse-remote-vlan/pull/107

Signed-off-by: Laszlo Kiraly <laszlo.kiraly@est.tech>
@ljkiraly ljkiraly mentioned this pull request Nov 10, 2022
Merged
ljkiraly added a commit to Nordix/nsm-sdk-vpp that referenced this pull request Nov 14, 2022
@ljkiraly
Fix MTU adjustment in case of remote vlan mechanism
ae56934 
The MTU should be updated in connection context based on the host
interface MTU in vpp instead of the sub-interface MTU.

Related PR: networkservicemesh/cmd-nse-remote-vlan/pull/107

Signed-off-by: Laszlo Kiraly <laszlo.kiraly@est.tech>
ljkiraly added a commit to Nordix/nsm-sdk-vpp that referenced this pull request Nov 19, 2022
@ljkiraly
Fix MTU adjustment in case of remote vlan mechanism
407877a 
The MTU should be updated in connection context based on the host
interface MTU in vpp instead of the sub-interface MTU.

Related PR: networkservicemesh/cmd-nse-remote-vlan/pull/107

Signed-off-by: Laszlo Kiraly <laszlo.kiraly@est.tech>
edwarnicke pushed a commit to networkservicemesh/sdk-vpp that referenced this pull request Nov 19, 2022
@ljkiraly
Fix MTU adjustment in case of remote vlan mechanism (#656)
89baf2c 
The MTU should be updated in connection context based on the host
interface MTU in vpp instead of the sub-interface MTU.

Related PR: networkservicemesh/cmd-nse-remote-vlan/pull/107

Signed-off-by: Laszlo Kiraly <laszlo.kiraly@est.tech>

Signed-off-by: Laszlo Kiraly <laszlo.kiraly@est.tech>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-vpp that referenced this pull request Nov 19, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
373481b 
…k-vpp@main

PR link: networkservicemesh/sdk-vpp#656

Commit: 89baf2c
Author: Laszlo Kiraly
Date: 2022-11-19 19:14:53 +0100
Message:
  - Fix MTU adjustment in case of remote vlan mechanism (#656)
The MTU should be updated in connection context based on the host
interface MTU in vpp instead of the sub-interface MTU.

Related PR: networkservicemesh/cmd-nse-remote-vlan/pull/107

Signed-off-by: Laszlo Kiraly <laszlo.kiraly@est.tech>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-firewall-vpp that referenced this pull request Nov 19, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
55ff01c 
…k-vpp@main

PR link: networkservicemesh/sdk-vpp#656

Commit: 89baf2c
Author: Laszlo Kiraly
Date: 2022-11-19 19:14:53 +0100
Message:
  - Fix MTU adjustment in case of remote vlan mechanism (#656)
The MTU should be updated in connection context based on the host
interface MTU in vpp instead of the sub-interface MTU.

Related PR: networkservicemesh/cmd-nse-remote-vlan/pull/107

Signed-off-by: Laszlo Kiraly <laszlo.kiraly@est.tech>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-icmp-responder-vpp that referenced this pull request Nov 19, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
b6338cf 
…k-vpp@main

PR link: networkservicemesh/sdk-vpp#656

Commit: 89baf2c
Author: Laszlo Kiraly
Date: 2022-11-19 19:14:53 +0100
Message:
  - Fix MTU adjustment in case of remote vlan mechanism (#656)
The MTU should be updated in connection context based on the host
interface MTU in vpp instead of the sub-interface MTU.

Related PR: networkservicemesh/cmd-nse-remote-vlan/pull/107

Signed-off-by: Laszlo Kiraly <laszlo.kiraly@est.tech>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-simple-vl3-docker that referenced this pull request Nov 19, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
317b60c 
…k-vpp@main

PR link: networkservicemesh/sdk-vpp#656

Commit: 89baf2c
Author: Laszlo Kiraly
Date: 2022-11-19 19:14:53 +0100
Message:
  - Fix MTU adjustment in case of remote vlan mechanism (#656)
The MTU should be updated in connection context based on the host
interface MTU in vpp instead of the sub-interface MTU.

Related PR: networkservicemesh/cmd-nse-remote-vlan/pull/107

Signed-off-by: Laszlo Kiraly <laszlo.kiraly@est.tech>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vlan-vpp that referenced this pull request Nov 19, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
d76e78a 
…k-vpp@main

PR link: networkservicemesh/sdk-vpp#656

Commit: 89baf2c
Author: Laszlo Kiraly
Date: 2022-11-19 19:14:53 +0100
Message:
  - Fix MTU adjustment in case of remote vlan mechanism (#656)
The MTU should be updated in connection context based on the host
interface MTU in vpp instead of the sub-interface MTU.

Related PR: networkservicemesh/cmd-nse-remote-vlan/pull/107

Signed-off-by: Laszlo Kiraly <laszlo.kiraly@est.tech>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-forwarder-vpp that referenced this pull request Nov 19, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
b4eb76d 
…k-vpp@main

PR link: networkservicemesh/sdk-vpp#656

Commit: 89baf2c
Author: Laszlo Kiraly
Date: 2022-11-19 19:14:53 +0100
Message:
  - Fix MTU adjustment in case of remote vlan mechanism (#656)
The MTU should be updated in connection context based on the host
interface MTU in vpp instead of the sub-interface MTU.

Related PR: networkservicemesh/cmd-nse-remote-vlan/pull/107

Signed-off-by: Laszlo Kiraly <laszlo.kiraly@est.tech>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-simple-docker that referenced this pull request Nov 19, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
307e766 
…k-vpp@main

PR link: networkservicemesh/sdk-vpp#656

Commit: 89baf2c
Author: Laszlo Kiraly
Date: 2022-11-19 19:14:53 +0100
Message:
  - Fix MTU adjustment in case of remote vlan mechanism (#656)
The MTU should be updated in connection context based on the host
interface MTU in vpp instead of the sub-interface MTU.

Related PR: networkservicemesh/cmd-nse-remote-vlan/pull/107

Signed-off-by: Laszlo Kiraly <laszlo.kiraly@est.tech>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vl3-vpp that referenced this pull request Nov 19, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
bf913f1 
…k-vpp@main

PR link: networkservicemesh/sdk-vpp#656

Commit: 89baf2c
Author: Laszlo Kiraly
Date: 2022-11-19 19:14:53 +0100
Message:
  - Fix MTU adjustment in case of remote vlan mechanism (#656)
The MTU should be updated in connection context based on the host
interface MTU in vpp instead of the sub-interface MTU.

Related PR: networkservicemesh/cmd-nse-remote-vlan/pull/107

Signed-off-by: Laszlo Kiraly <laszlo.kiraly@est.tech>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Nov 19, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljkiraly ljkiraly Awaiting requested review from ljkiraly

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@LionelJouin