Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onidle chain element into cmd-nse-icmp-responder and cover it by docker tests #189

Merged
merged 12 commits into from
May 21, 2021
Merged

Conversation

d-uzlov
Copy link
Contributor

@d-uzlov d-uzlov commented May 14, 2021

fixes #188

@d-uzlov d-uzlov marked this pull request as ready for review May 14, 2021 05:45
Comment on lines 50 to 56
f.Require().Eventually(func() bool {
healthResponse, err = healthClient.Check(ctx, hcRequest)
return err != nil
}, f.idleTimeout+time.Second, time.Millisecond*50)
f.Require().Nil(healthResponse)
f.Require().Error(err)
f.Require().Equal(codes.Unavailable, grpcutils.UnwrapCode(err))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is not good to shut down the endpoint in the suite because it can break the next tests in the suite.
Can we create a separate test for onidle case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to make a separate test, and it had hanging-forever issues, probably because current suite setup code doesn't account for the possibility that it can be run several times.

Currently suite only has 1 test. I tried to think of which tests can be added to it, and didn't come up with anything, so I figured out I can just make this test terminating.

I'll try to modify the setup code we are expecting the we will add more tests to this suite in the future.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@d-uzlov d-uzlov marked this pull request as draft May 14, 2021 08:08
@denis-tingaikin denis-tingaikin self-assigned this May 14, 2021
main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
d-uzlov added 12 commits May 19, 2021 12:03
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
Signed-off-by: Danil Uzlov <DanilUzlov@yandex.ru>
@d-uzlov d-uzlov marked this pull request as ready for review May 19, 2021 07:02
@edwarnicke
Copy link
Member

LGTM

@denis-tingaikin denis-tingaikin merged commit c8f6a6b into networkservicemesh:main May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add onidle chain element into cmd-nse-icmp-responder and cover it by docker tests
4 participants