Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of replicaSet #150

Open
anastasia-malysheva opened this issue Jun 10, 2022 · 2 comments
Open

Add support of replicaSet #150

anastasia-malysheva opened this issue Jun 10, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@anastasia-malysheva
Copy link
Contributor

anastasia-malysheva commented Jun 10, 2022

ReplicaSet kind doesn't supported by webhook: https://github.com/networkservicemesh/cmd-admission-webhook-k8s/blob/main/main.go#L106

@denis-tingaikin
Copy link
Member

denis-tingaikin commented Jun 10, 2022

It would be nice if we can support other container based k8s resources (if we missed something).

@denis-tingaikin denis-tingaikin added this to the v1.5.0 milestone Jun 13, 2022
@anastasia-malysheva
Copy link
Contributor Author

As part of the task it was found that Job and CronJob K8s resourсes can be supported with ТЫЬ annotations too, but it is not necessary now so it was not added.

Also the small research was made about usage of Annotations in service meshes, Istio and Consul-k8s.

For Consul annotations are widely used for pods, but also they are used for Services and Service Accounts and there are examples with custom kinds.
Consul Docs: https://www.consul.io/docs/k8s/annotations-and-labels#consul-hashicorp-com-consul-sidecar-memory-limit
Consul example with annotations for Service https://github.com/hashicorp/consul/blob/b199b60ded9b22d0be3cdd9b0947dcaa98194baa/website/content/docs/k8s/service-sync.mdx
Example with custom kind ServiceDefaults: https://github.com/hashicorp/consul/blob/21e855d860865f1472b3fdcb64a916e92bc83a9f/website/content/docs/k8s/crds/upgrade-to-crds.mdx (edited)

For Istio annotations used also for Pods, Deployments, Services and other types too.
In istio doc listed that some annotations are used for any kind: https://istio.io/latest/docs/reference/config/annotations/
Example with deployment https://github.com/istio/istio/blob/393f88cd255f1c0caea6fac5d21aaf0d3e412aad/pilot/pkg/config/kube/gateway/templates/deployment.yaml
example with Gateway https://github.com/istio/istio/blob/9f83137301787eea4b3f547ae8e74d862f104c72/pilot/pkg/config/kube/gateway/testdata/route-binding.yaml.golden

nsmbot pushed a commit that referenced this issue Nov 8, 2022
…k@main

PR link: networkservicemesh/sdk#1380

Commit: e51c7ad
Author: Network Service Mesh Bot
Date: 2022-11-08 05:45:00 -0600
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/api@main (#1380)
PR link: networkservicemesh/api#150

Commit: f71f283
Author: Nikita Skrynnik
Date: 2022-11-08 17:52:51 +0700
Message:
    - add automerge reusable workflow (#150)
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit that referenced this issue Nov 9, 2022
…k@main

PR link: networkservicemesh/sdk#1380

Commit: e51c7ad
Author: Network Service Mesh Bot
Date: 2022-11-08 05:45:00 -0600
Message:
  - Update go.mod and go.sum to latest version from networkservicemesh/api@main (#1380)
PR link: networkservicemesh/api#150

Commit: f71f283
Author: Nikita Skrynnik
Date: 2022-11-08 17:52:51 +0700
Message:
    - add automerge reusable workflow (#150)
Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants