Add REFRESH_REQUESTED connection state #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
| @@ -18,7 +18,7 @@ | |||
| // Code generated by protoc-gen-go. DO NOT EDIT. | |||
| // versions: | |||
| // protoc-gen-go v1.26.0 | |||
| // protoc v3.17.3 | |||
There was a problem hiding this comment.
Is this change expected? Can we be consistent with other pieces?
There was a problem hiding this comment.
Yes, this is expected. In this PR we are fixing the version because our normal version is 3.14.0 - https://github.com/networkservicemesh/api/blob/main/.github/workflows/ci.yaml#L102
Other versions - apparently typos from previous PRs.
denis-tingaikin
approved these changes
Jul 11, 2022
nsmbot
pushed a commit
to networkservicemesh/sdk
that referenced
this pull request
Jul 11, 2022
…i@main PR link: networkservicemesh/api#146 Commit: a596890 Author: Artem Glazychev Date: 2022-07-11 22:39:18 +0700 Message: - Add REFRESH_REQUESTED connection state (#146) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk
that referenced
this pull request
Jul 26, 2022
…i@main PR link: networkservicemesh/api#146 Commit: a596890 Author: Artem Glazychev Date: 2022-07-11 22:39:18 +0700 Message: - Add REFRESH_REQUESTED connection state (#146) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: networkservicemesh/cmd-nse-vl3-vpp#77
Signed-off-by: Artem Glazychev artem.glazychev@xored.com