Feature/light stream common functions #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
KalevGonvick
commented
Mar 4, 2022
- Added 2 common functions to Light Streams to get value from ReadOnlyKeyValueStore, one for a specific key and the other is for all.
stevehu
reviewed
Mar 4, 2022
| } | ||
| } | ||
| } while (storeMoved); | ||
| if(returnObj == null) { |
There was a problem hiding this comment.
I think this logging statement is miss leading. It might reach here immediately if the key is not in the current instance. Should we just remove it?
stevehu
reviewed
Mar 4, 2022
kafka-entity/pom.xml
Outdated
| @@ -21,7 +21,7 @@ | |||
| <parent> | |||
| <groupId>com.networknt</groupId> | |||
| <artifactId>light-kafka</artifactId> | |||
| <version>2.1.1-SNAPSHOT</version> | |||
| <version>2.1.2-SNAPSHOT</version> | |||
There was a problem hiding this comment.
We don't have 2.1.2-SNAPSHOT yet. Let's use the 2.1.1-SNAPSHOT for now.
stevehu
approved these changes
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.