Skip to content

Commit

Permalink
fixes #199 add pre-commit hook and apply it (#200)
Browse files Browse the repository at this point in the history
  • Loading branch information
stevehu authored Feb 8, 2024
1 parent b1e4071 commit e5dec79
Show file tree
Hide file tree
Showing 17 changed files with 28 additions and 31 deletions.
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,4 @@ exec-develop-build/bin/
exec-regex-replace/bin/
exec-release-docker/bin/
exec-release-maven/bin/
exec-version-upgrade/bin/
exec-version-upgrade/bin/
14 changes: 14 additions & 0 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
repos:
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v3.2.0
hooks:
- id: trailing-whitespace
- id: end-of-file-fixer
- id: check-yaml
- id: check-added-large-files
- repo: https://github.com/networknt/pre-commit-hook-keyword
rev: f17c4de14fc24420f6768c19cad06ba03af06d86
hooks:
- id: keywordscan
args: ["--keywords=c3VubGlmZQ==,Y2liYw==,c3VuIGxpZmU="]
types: ["text"]
Original file line number Diff line number Diff line change
Expand Up @@ -78,4 +78,4 @@ public static Schema getSchema(Object object) {
+ "Float, Double, String, byte[] and IndexedRecord");
}
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -403,4 +403,4 @@ public void remove() {
};
}

}
}
10 changes: 0 additions & 10 deletions kafka-common/src/main/java/com/networknt/kafka/common/EventId.java
Original file line number Diff line number Diff line change
Expand Up @@ -478,13 +478,3 @@ public EventId build() {
}
}
}










Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,4 @@ public byte[] serialize(String topic, T data) {
public void close() {
}

}
}
Original file line number Diff line number Diff line change
Expand Up @@ -289,4 +289,4 @@ public void testRepeatedSerialization() throws Exception {
assertEquals(true, b3.contains("c"));
}

}
}
1 change: 0 additions & 1 deletion kafka-common/src/test/resources/config/kafka-consumer.yml
Original file line number Diff line number Diff line change
Expand Up @@ -99,4 +99,3 @@ iteratorBackoffMs: ${kafka-consumer.iteratorBackoffMs:50}
#keep alive time out occurs and sidecar consumer does not move forward. Hence we are adding this property so that we can explicitly close the connection
#when we receive the response and not wait for FinAck.
backendConnectionReset: ${kafka-consumer.backendConnectionReset:false}

2 changes: 1 addition & 1 deletion kafka-common/src/test/resources/config/kafka-ksqldb.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,4 @@ properties:
# Backend API host
backendUrl: ${kafka-ksqldb.backendUrl:https://localhost:8080}
# Backend API path
backendPath: ${kafka-ksqldb.backendPath:/kafka/ksqldb}
backendPath: ${kafka-ksqldb.backendPath:/kafka/ksqldb}
Original file line number Diff line number Diff line change
Expand Up @@ -56,4 +56,3 @@ public String toString() {
+ '}';
}
}

Original file line number Diff line number Diff line change
Expand Up @@ -597,4 +597,3 @@ protected Map<String, String> convertHeaders(Headers headers) {
return headerMap;
}
}

Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,14 @@

public class KsqlDbPullQueryRequest {



public enum OffsetEnum {

EARLIEST ("earliest"),

LATEST ("latest");


private final String value;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,3 @@ default Headers getHeaders() {
return headers;
}
}



Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public final class TopicPartition {
private final String topic;

private final Integer partition;

public TopicPartition(
@JsonProperty("topic") String topic,
@JsonProperty("partition") Integer partition
Expand Down
2 changes: 1 addition & 1 deletion kafka-entity/src/test/resources/config/kafka-producer.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,4 +52,4 @@ retries: ${kafka-producer.retries:0}
# The maximum number of unacknowledged requests the client will send on a single connection before blocking. Note that if
# this setting is set to be greater than 1 and there are failed sends, there is a risk of message re-ordering due to retries
# (i.e., if retries are enabled).
maxInFlightRequestsPerConnection: ${kafka-producer.maxInFlightRequestsPerConnection:5}
maxInFlightRequestsPerConnection: ${kafka-producer.maxInFlightRequestsPerConnection:5}
2 changes: 1 addition & 1 deletion kafka-entity/src/test/resources/config/kafka-streams.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@ bootstrapServers: localhost:9092
processingGuarantee: exactly_once
replicationFactor: 3
# Only set to true right after the streams reset.
cleanUp: false
cleanUp: false
Original file line number Diff line number Diff line change
Expand Up @@ -88,4 +88,3 @@ public static <T, E extends Throwable> CompletableFuture<T> catchingCompose(
.thenCompose(wrapped -> wrapped);
}
}

0 comments on commit e5dec79

Please sign in to comment.