Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decryptor module is missing in the generated pom.xml file #300

Closed
GavinChenYan opened this issue May 20, 2019 · 2 comments
Closed

decryptor module is missing in the generated pom.xml file #300

GavinChenYan opened this issue May 20, 2019 · 2 comments

Comments

@GavinChenYan
Copy link
Contributor

in the codegen, the config.xml need the decryptor module dependency in the pom file
${config.decryptorClass:com.networknt.decrypt.AESDecryptor}

@stevehu
Copy link
Contributor

stevehu commented May 21, 2019

There is an additional issue with the config.yml file generation. The config.yml needs to be in the

  "generateEnvVars": {
    "generate": true,
    "skipArray": true,
    "skipMap": true,
    "exclude": [
      "handerl.yml",
      "values.yml",
      "config.yml"
    ]
  }

in the config.json file as the input for the light-codegen. This is not acceptable as existing users won't know to add this section correctly. We need somehow make it as a default. Or we can manually update the template instead of using the YAMLFileParameterizer class blindly.

@stevehu
Copy link
Contributor

stevehu commented May 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants