Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenAPI spec Reusable Enums not supported #176

Closed
DSchrupert opened this issue Sep 5, 2018 · 2 comments
Closed

OpenAPI spec Reusable Enums not supported #176

DSchrupert opened this issue Sep 5, 2018 · 2 comments
Assignees
@auahmed

Comments

@DSchrupert
Copy link
Member

From the looks of it, the codegen doesn't currently support generating Reusable Enums per openapi specification outlined here:
https://swagger.io/docs/specification/data-models/enums/

Is there any plan to implement this?
@stevehu
Copy link
Contributor

stevehu commented Sep 5, 2018

Currently, enums are generated inline within the parent class. It should be very easy to make the change to generate a separate enum file from components. In the OpenAPI generator, we have access to the openapi-parser API and it would be very easy to generate classes based on the json overlay object. Do you want to take a look at it?

@DSchrupert DSchrupert assigned auahmed and unassigned stevehu Sep 5, 2018
auahmed pushed a commit that referenced this issue Sep 6, 2018
#176 support seperate enum classes
eb13679
stevehu added a commit that referenced this issue Sep 6, 2018
@stevehu
Merge pull request #177 from networknt/feature/#176-enum-class
0086e6c 
#176 support seperate enum classes
@DSchrupert
Copy link
Member Author

Thank you @auahmed !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@auahmed auahmed

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stevehu @auahmed @DSchrupert