Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix explicit disabling of format assertions #1145

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

justin-tay
Copy link
Contributor

Closes #1144

This also fixes the SchemaValidatorsConfig builder to initialise formatAssertionsEnabled to null instead of false.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.10%. Comparing base (48ca3c2) to head (442f456).
Report is 76 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1145      +/-   ##
============================================
- Coverage     78.90%   78.10%   -0.80%     
- Complexity     1965     2059      +94     
============================================
  Files           172      201      +29     
  Lines          6352     6851     +499     
  Branches       1255     1252       -3     
============================================
+ Hits           5012     5351     +339     
- Misses          867     1033     +166     
+ Partials        473      467       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevehu stevehu merged commit 77c91a2 into networknt:master Jan 17, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disabling format assertions for draft-07 doesn't seem to work
3 participants