Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to latest janus 0.x #23

Merged
merged 7 commits into from
Feb 12, 2022
Merged

Conversation

vincentfretin
Copy link
Member

@vincentfretin vincentfretin commented Jan 22, 2022

Upgrade janus to latest 0.11.7 version.
Compared to v0.11.1, changes that may interest us are related to faster parsing and writing sdp.

[v0.11.5] - 2021-10-18

[v0.11.6] - 2021-12-13

  • The API was incremented from 15 to 16 because of a new auth_is_signed function in the Plugin interface, that is used in the videoroom plugin.
    meetecho/janus-gateway@f9906da
    This change will need a change in janus-plugin-rs and janus-plugin-sfu. For now, we can do a build without this commit.
  • Grow buffer as needed when generating SDPs [PR-2797]
    meetecho/janus-gateway@326b00c

[v0.11.7] - 2022-01-24

I leave this in draft for now, mainly because this currently uses my fork. Changes in janus-plugin-rs and janus-plugin-sfu should be properly done instead. Also I'll test that on my server before merging.

@vincentfretin
Copy link
Member Author

I think I will fork janus-plugin-sfu and janus-plugin-rs in the networked-aframe organization and have a community branch there (or just use master?) that have some of my pending PRs merged:

@mqp if you read this, do I still need to bother doing PRs on the mozilla repositories? Or should I just fork and do future PRs on my forks? Anyway, I'll be glad if you have time reviewing any of my existing or future PR.

@feymartynov if you work on a PR for janus-plugin-rs to update to API 16 before me, let me know :)
I'll probably do that in the coming weeks, but no promises.

@feymartynov
Copy link

if you work on a PR for janus-plugin-rs to update to API 16 before me, let me know

No, I don't.

@mqp
Copy link
Collaborator

mqp commented Feb 4, 2022 via email

@vincentfretin
Copy link
Member Author

Watch the two repos I forked to be notified of new issues and PR.

https://github.com/networked-aframe/janus-plugin-sfu
I merged my two pending PRs in master.

https://github.com/networked-aframe/janus-plugin-rs
I'll create a branch for api 16 in this fork and still create a PR to mozilla's repo, because this is still a shared package that other plugins use and only @mqp can do a release.

@vincentfretin
Copy link
Member Author

Changes for API 16:
mozilla/janus-plugin-rs#31
networked-aframe/janus-plugin-sfu#1

@vincentfretin vincentfretin marked this pull request as ready for review February 12, 2022 17:20
@vincentfretin vincentfretin merged commit ac4525d into master Feb 12, 2022
@vincentfretin vincentfretin deleted the upgrade-janus-to-latest-0.x branch February 12, 2022 17:29
@vincentfretin
Copy link
Member Author

@calvincs see install doc that uses janus 0.11.8 and networked-aframe/janus-plugin-sfu master

@calvincs
Copy link

Looks good, it works when I follow the steps. Thanks for your efforts on this!

@vincentfretin
Copy link
Member Author

I merged all my pending PR in naf fork https://github.com/networked-aframe/janus-plugin-rs
I'll work on api 17 directly there.

@vincentfretin
Copy link
Member Author

I updated to janus 0.13.0 api 17 in #41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants