-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade to latest janus 0.x #23
Conversation
I think I will fork janus-plugin-sfu and janus-plugin-rs in the networked-aframe organization and have a community branch there (or just use master?) that have some of my pending PRs merged:
@mqp if you read this, do I still need to bother doing PRs on the mozilla repositories? Or should I just fork and do future PRs on my forks? Anyway, I'll be glad if you have time reviewing any of my existing or future PR. @feymartynov if you work on a PR for janus-plugin-rs to update to API 16 before me, let me know :) |
No, I don't. |
This is a good idea and I totally give my seal of approval, since I'm not
working on this stuff anymore (and I don't think Hubs uses it anymore
either) it doesn't make sense to have me in the loop. I'll take a look at
those PRs.
…On Fri, Feb 4, 2022, 01:09 Vincent Fretin ***@***.***> wrote:
I think I will fork janus-plugin-sfu and janus-plugin-rs in the
networked-aframe organization and have a community branch there (or just
use master?) that have some of my pending PRs merged:
- mozilla/janus-plugin-sfu#94
<mozilla/janus-plugin-sfu#94>
- mozilla/janus-plugin-sfu#90
<mozilla/janus-plugin-sfu#90>
- mozilla/janus-plugin-rs#29
<mozilla/janus-plugin-rs#29>
- mozilla/janus-plugin-rs#28
<mozilla/janus-plugin-rs#28>
@mqp <https://github.com/mqp> if you read this, do I still need to bother
doing PRs on the mozilla repositories? Or should I just fork and do future
PRs on my forks? Anyway, I'll be glad if you have time reviewing any of my
existing or future PR.
@feymartynov <https://github.com/feymartynov> if you work on a PR for
janus-plugin-rs to update to API 16 before me, let me know :)
I'll probably do that in the coming weeks, but no promises.
—
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADIUXP7C7VTPML3R5I5DGTUZOJS3ANCNFSM5MSEDACA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Watch the two repos I forked to be notified of new issues and PR. https://github.com/networked-aframe/janus-plugin-sfu https://github.com/networked-aframe/janus-plugin-rs |
Changes for API 16: |
@calvincs see install doc that uses janus 0.11.8 and networked-aframe/janus-plugin-sfu master |
Looks good, it works when I follow the steps. Thanks for your efforts on this! |
I merged all my pending PR in naf fork https://github.com/networked-aframe/janus-plugin-rs |
I updated to janus 0.13.0 api 17 in #41 |
Upgrade janus to latest 0.11.7 version.
Compared to v0.11.1, changes that may interest us are related to faster parsing and writing sdp.
[v0.11.5] - 2021-10-18
meetecho/janus-gateway@90147ba
meetecho/janus-gateway@f2ed527
[v0.11.6] - 2021-12-13
meetecho/janus-gateway@f9906da
This change will need a change in janus-plugin-rs and janus-plugin-sfu. For now, we can do a build without this commit.
meetecho/janus-gateway@326b00c
[v0.11.7] - 2022-01-24
meetecho/janus-gateway@4e86131
meetecho/janus-gateway@fc9ece3
I leave this in draft for now, mainly because this currently uses my fork. Changes in janus-plugin-rs and janus-plugin-sfu should be properly done instead. Also I'll test that on my server before merging.