Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add env variables EVENT_LOOPS and ALLOW_LOOP_INDICATION #7

Merged
merged 1 commit into from
Nov 12, 2023
Merged

Conversation

hjopel
Copy link

@hjopel hjopel commented Jun 14, 2023

As discussed here, this PR introduces EVENT_LOOPS and ALLOW_LOOP_INDICATION env variables for docker.

Copy link
Member

@vincentfretin vincentfretin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, there is an error in the variable example. Can you add more doc please?

In order to take advantage of event loops / loop indication, the respective environment variables are available:

```
EVENT_LOOPS="true"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not "true", 8 for example (number of CPUs)
Can you remove the quotes from the values for consistency with the other variables in this doc.
Also please add the two variables in docker/docker-compose.yml as well.
You can add a reference to https://github.com/meetecho/janus-gateway/pull/2450 for context.
Also please specify you will need to configure adapter.setEventLoops(8) (same value that what you configured in the environment variable) with naf-janus-adapter as well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you at least fix EVENT_LOOPS="true" by EVENT_LOOPS=8 please? I'll merge and add some more text to the doc. Thanks.

@vincentfretin
Copy link
Member

@hjopel Can you please do the requested changes?

@hjopel
Copy link
Author

hjopel commented Jun 21, 2023

@hjopel Can you please do the requested changes?

yes apologies, it fell under my radar. will try and do the changes until the weekend

@vincentfretin vincentfretin merged commit 1fcd458 into networked-aframe:master Nov 12, 2023
@vincentfretin
Copy link
Member

documentation added in #8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants