Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IGNORE] #334

Closed
wants to merge 2 commits into from
Closed

[IGNORE] #334

wants to merge 2 commits into from

Conversation

mildabre
Copy link
Contributor

On nette forum in this post: https://forum.nette.org/cs/36685-latte-addfilter-neni-tam-chyba#p227757 was reported error - mismatch between typehints of parameter $name in methods addFilter() in Nette\Bridges\ApplicationLatte\Template and Latte\Engine, the correct typehint is defined by typehint of second parameter of php function preg_match() which is string. Consequently the correct typehint of parameter $name in method Nette\Bridges\ApplicationLatte\Template::addFilter() is pure string not nullable string

On nette forum in this post: https://forum.nette.org/cs/36685-latte-addfilter-neni-tam-chyba#p227757 was reported error - mismatch between typehints of parameter $name in methods addFilter() in Nette\Bridges\ApplicationLatte\Template and Latte\Engine, the correct typehint is defined by typehint of second parameter of php function preg_match() which is string. Consequently the correct typehint of parameter $name in method Nette\Bridges\ApplicationLatte\Template::addFilter() is pure string not nullable string
After changes of syntax in neon statements and added support for properties it is necessary to adjust syntax of argument 'withoutUserInfo' and add suffix '()' used now for methods
@mildabre mildabre closed this Nov 23, 2024
@mildabre mildabre deleted the patch-5 branch November 23, 2024 19:12
@dg dg changed the title Unify typehints of parameter $name in methods addFilter() [IGNORE] Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant