Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(privateapps): resourcePrivateAppsRead function #32

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

julianmaze
Copy link

feat(privateapps): resourcePrivateAppsRead function

This feature implements the resourcePrivateAppsRead function to accomplish two vital pieces of the infrastructure lifecycle for Netskope private apps:

  1. Refresh Netskope private apps that exist in state
  2. Import Netskope private apps that do not exist in state

This change is vital to ensure Terraform stays the single source of truth for Netskope private apps. If private app settings change outside of Terraform the resourcePrivateAppsRead function is called to refresh Terraform state. The function doubles as import logic because of its ability to refresh the private app based on the ID alone.

Additional Changes

  • README formatting changes
  • Private app import documentation
  • Version bump

Closes #31

terraform-provider-ns considerations

I have seen the new provider in the works and read through netskopeoss/terraform-provider-ns#11. I understand it will replace this provider. Once it is ready, our team is happy to migrate to it, but we need the private app refresh/import functionality ASAP.

@julianmaze julianmaze force-pushed the feature/refresh-private-app-state branch from e371aac to d89bbf4 Compare November 13, 2024 00:42
@jeazy23
Copy link

jeazy23 commented Nov 19, 2024

Could we get a review on this PR? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Private App Resource State Not Refreshing
2 participants