Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: application #150

Merged
merged 1 commit into from
Aug 10, 2023
Merged

refactor: application #150

merged 1 commit into from
Aug 10, 2023

Conversation

lspgn
Copy link
Member

@lspgn lspgn commented Mar 24, 2023 •
edited
Loading

A refactor with:

  • Better logging
  • Remove Prometheus counters from libraries, keep in GoFlow2
  • Sync Pool for protobuf
  • UDP Routines with proper quit
  • Pass parsing error to logger
  • Default reuseport
  • Common decode for netflow-v5/netflow-v9/ipfix

@lspgn lspgn changed the title refactor: log refactor: application Mar 24, 2023
@lspgn lspgn force-pushed the app/refactor branch 2 times, most recently from c333b7e to 42c5c1a Compare March 29, 2023 07:13
@lspgn lspgn mentioned this pull request Mar 31, 2023
Closed
@lspgn
Copy link
Member Author

lspgn commented Apr 16, 2023

allocations.patch

Tried to implement #141
but did not notice major changes in decoding performance

This was referenced Apr 16, 2023
Closed
Closed
Closed
Closed
Closed
Closed
@lspgn
Copy link
Member Author

lspgn commented Apr 16, 2023

Missing the template module feature.
I believe this is the opportunity to avoid using the init + registration since one may want to reuse the template library

@lspgn lspgn mentioned this pull request Apr 16, 2023
Closed
@lspgn lspgn marked this pull request as ready for review August 10, 2023 02:47
@lspgn lspgn merged commit ae56e41 into main Aug 10, 2023
@lspgn lspgn deleted the app/refactor branch August 10, 2023 02:47
fionera
fionera reviewed Nov 20, 2024
View reviewed changes
pb/flow.proto
uint32 sequence_num = 4;
uint64 sampling_rate = 3;

uint32 flow_direction = 42;
//uint32 flow_direction = 42;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this commented out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fionera fionera fionera left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lspgn @fionera