Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to set additional API parameters #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andriykorchak
Copy link

Hi @netmanchris,

Thanks for the great library.

Please review this PR - I added ability to set additional API parameters in conn.get_data() and data.get_raw_data().

One of the possible application example - filter raw data by date/time.

Thanks,

Andrii

@netmanchris
Copy link
Owner

Hey @andriykorchak Really appreciate you adding to this. Are you comfortable adding a couple of test examples using the new params feature? It looks like the changes you made haven’t broken any of the current test which is great, but I’d like to make sure we add the new test to make sure we don’t accidentally break something in the future.

@andriykorchak
Copy link
Author

Sure, will do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants