chore!: use pure ES modules #435
Conversation
| @@ -0,0 +1,15 @@ | |||
| #!/usr/bin/env node | |||
There was a problem hiding this comment.
This repository's ESLint configuration is used both for our other repositories and for this repository itself.
We cannot change the ESLint configuration to make it assume that *.js are pure ES modules yet until all our repositories have migrated.
Because of this, we need to use *.mjs files in this repository for the moment. Therefore, this PR renames several *.js to *.mjs.
| @@ -105,5 +107,8 @@ | |||
| }, | |||
| "engines": { | |||
| "node": ">=16.0.0" | |||
| }, | |||
| "ava": { | |||
| "verbose": true | |||
There was a problem hiding this comment.
Like our other repositories, moving the ava configuration to package.json solves some issues with pure ES modules.
291b7d4 to
6e80dad
Compare
6e80dad to
6ceb9a4
Compare
| @@ -1,28 +1,30 @@ | |||
| { | |||
| "name": "@netlify/eslint-config-node", | |||
| "version": "4.1.7", | |||
| "main": ".eslintrc.js", | |||
| "type": "commonjs", | |||
There was a problem hiding this comment.
| ``` | ||
|
|
||
| - Copy the `.editorconfig` and `.gitattributes` files relativity to the root of the project. | ||
| - Copy the `commitlint.config.cjs`, `.editorconfig` and `.gitattributes` files relativity to the root of the project. |
There was a problem hiding this comment.
Saw it was copy paste but should s/relativity/relative/? 🤔
| - Copy the `commitlint.config.cjs`, `.editorconfig` and `.gitattributes` files relativity to the root of the project. | |
| - Copy the `commitlint.config.cjs`, `.editorconfig` and `.gitattributes` files relative to the root of the project. |
There was a problem hiding this comment.
Ah, it's been automerged :-/
Good catch, I have opened a PR at #438 to fix it.
Part of https://github.com/netlify/team-dev/issues/36
This migrates this repository to pure ES modules.
Checklist
Please add a
xinside each checkbox: