fix(deps): update husky package to the latest #403

XhmikosR · 2022-01-08T10:33:41Z

🎉 Thanks for sending this pull request! 🎉

Please make sure the title is clear and descriptive.

If you are fixing a typo or documentation, please skip these instructions.

Otherwise please fill in the sections below.

Which problem is this pull request solving?

Example: I'm always frustrated when [...]

List other issues or pull requests related to this problem

Example: This fixes #5012

Describe the solution you've chosen

Example: I've fixed this by [...]

Describe alternatives you've considered

Example: Another solution would be [...]

Checklist

Please add a x inside each checkbox:

I have read the contribution guidelines.
The status checks are successful (continuous integration). Those can be seen below.

XhmikosR · 2022-01-10T13:18:08Z

package.json

@@ -60,10 +56,14 @@
    "fp"
  ],
  "license": "Apache-2.0",
-  "repository": "netlify/eslint-config-node",
+  "repository": {


These are automatically added by npm init. We can still just use "repository": "netlify/eslint-config-node" but the bugs and homepage properties are redundant. Let me know which one you prefer. I personally just go with the explicit npm init properties but both should have the same effect.

XhmikosR · 2022-01-10T17:26:16Z

In order for this to apply, manual steps will be needed in your projects:

remove husky from the upstream devDependencies
create the needed changes to migrate

The second step can be done semi-automatically, there are instructions in the husky releases page which is what I used here myself.

ehmicky · 2022-01-10T17:42:15Z

.husky/pre-push

@@ -0,0 +1,4 @@
+#!/bin/sh


While this is uncommon, some Windows systems are lacking sh. Is there a way to use Husky v7 for those?

Yeah, I'm actually on Windows mostly and it works fine.

Most Windows developers have sh installed, but not all.
Sometimes, an alternative is to use a Node script instead. However, I am wondering whether this is possible with Husky v7?

This is unrelated to bash, I don't have bash at all. The changes you see here are from their official migration.

Also, these are git hooks, which work fine everywhere.

So, basically husky sets the core.hooksPath of the git repo (when doing npm install) to be ./.husky, hence how this works :)

EDIT: git for Windows ships with its own MSYS2 system which includes bash, to answer your question about bash. So, anyone who's installed Git on Windows does have everything set up. I'm on Windows myself (mostly) and this works fine.

I agree that most Windows developers have sh or Bash installed through git for Windows or other similar solutions. However, I have encountered some Windows developers who do not. While this is uncommon, I am wondering whether there is a way to make it work for them.

That being said, if Husky v7 does require sh, then this change sounds good to me.

What are your thoughts on this @erezrokah?

@ehmicky please read my comments :)

Not most, everyone who installs Git on Windows has MSYS2 -> bash. That's how Git works on Windows. This is nothing new, it's like that forever.

So, what you are seeing here is simply git hooks. How they are handled it's outside of the scope of the PR but I explained that above :)

Thanks @XhmikosR, I forgot that installing git implied installing Bash as well. You're absolutely correct.

ehmicky · 2022-01-10T17:43:33Z

package.json

  ],
  "bin": {
-    "run-e": "./bin/run_e.js",
-    "run-ci": "./bin/run_ci.js",
-    "run-local": "./bin/run_local.js"


In most of our repositories, we use exports, which requires file paths to start with ./. While removing in bin is possible, we might want to keep it for consistency. Also, this change might be unrelated to Husky?

This is done automatically by npm init -y. I can revert it, but I'd trust npm more here :)

But yeah it's unrelated to the husky update, I just ran npm init -y in this branch by mistake.

npm init should not be needed anymore for this repository, since it's already been initialized, so this should not be a problem for contributors?

I reverted the change already.

ehmicky · 2022-01-10T18:35:18Z

This looks good, thanks!
Would you like to please change the commit message from chore: to fix:? This will ensure our release-please bot creates a new release for this change.

XhmikosR · 2022-01-10T18:37:08Z

Can't you change it when squashing and merging? I'm away from my main machine right now

…

On Mon, Jan 10, 2022, 20:35 ehmicky ***@***.***> wrote: This looks good, thanks! Would you like to please change the commit message from chore: to fix:? This will ensure our release-please bot creates a new release for this change. — Reply to this email directly, view it on GitHub <#403 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACVLNJLNLSSKGOFIHH5GFDUVMRHHANCNFSM5LQO6BYA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.***>

ehmicky · 2022-01-12T18:43:47Z

I have tried it in netlify/js-client#657, and there might be a few additional tweaks needed:

XhmikosR · 2022-01-12T19:07:46Z

Sorry, about that! It worked fine for this project here and I thought it was OK. Feel free to revert the update if it's too much trouble :)

PS. I'm on Windows so I couldn't have noticed the permission issue :)

XhmikosR · 2022-01-12T19:37:54Z

Also, to clarify, someone will need to make the related changes to each project, i.e. it's not just a simple update. I should have communicated this better. So, this should have been a major version bump probably.

ehmicky · 2022-01-12T19:53:11Z

No worries @XhmikosR! We needed to make that upgrade, so this is very helpful. We just need to make a few tweaks and it will work. Also, I believe the old Husky setup still seems to work until the changes you are mentioning are performed.

You also did communicate the changes to be done 👍
The problem is that our bot is automatically merging the upgrade PRs, so we have to do this in separate PRs

I am currently trying to make it work on the netlify/js-client repository to see which are those changes, so we can then apply it on the other repositories 👍

XhmikosR · 2022-01-12T20:39:30Z

Thanks for your patience, I misjudged the upgrade for sure. Ideally, you should update but it looks like it might be a lot of trouble.

I'd be curious to see one project migrated. And don't feel bad reverting this PR if needed. I'd at least make it a major bump due to the manual work required :)

erezrokah added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Jan 10, 2022

XhmikosR commented Jan 10, 2022

View reviewed changes

XhmikosR marked this pull request as ready for review January 10, 2022 17:26

ehmicky reviewed Jan 10, 2022

View reviewed changes

ehmicky approved these changes Jan 10, 2022

View reviewed changes

ehmicky changed the title ~~chore(deps): update husky package to the latest~~ fix(deps): update husky package to the latest Jan 10, 2022

fix(deps): update husky package to the latest version

cb1e679

ehmicky merged commit d056fa8 into netlify:main Jan 12, 2022

token-generator-app bot mentioned this pull request Jan 12, 2022

chore(main): release 4.1.1 #412

Merged

XhmikosR deleted the update-husky branch January 12, 2022 18:08

This was referenced Jan 12, 2022

chore: remove pre-commit hook #414

Merged

fix: commitlint Git hook #415

Merged

ehmicky mentioned this pull request Jan 13, 2022

chore: fix Git Hooks netlify/js-client#659

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(deps): update husky package to the latest #403

fix(deps): update husky package to the latest #403

XhmikosR commented Jan 8, 2022 •

edited

Loading

XhmikosR Jan 10, 2022 •

edited

Loading

XhmikosR commented Jan 10, 2022 •

edited

Loading

ehmicky Jan 10, 2022

XhmikosR Jan 10, 2022

ehmicky Jan 10, 2022

XhmikosR Jan 10, 2022

XhmikosR Jan 10, 2022

XhmikosR Jan 10, 2022 •

edited

Loading

ehmicky Jan 10, 2022

XhmikosR Jan 10, 2022

XhmikosR Jan 10, 2022

ehmicky Jan 10, 2022 •

edited

Loading

ehmicky Jan 10, 2022

XhmikosR Jan 10, 2022

ehmicky Jan 10, 2022

XhmikosR Jan 10, 2022

ehmicky Jan 10, 2022

ehmicky commented Jan 10, 2022

XhmikosR commented Jan 10, 2022 via email

ehmicky commented Jan 12, 2022

XhmikosR commented Jan 12, 2022

XhmikosR commented Jan 12, 2022

ehmicky commented Jan 12, 2022 •

edited

Loading

XhmikosR commented Jan 12, 2022

fix(deps): update husky package to the latest #403

fix(deps): update husky package to the latest #403

Conversation

XhmikosR commented Jan 8, 2022 • edited Loading

XhmikosR Jan 10, 2022 • edited Loading

Choose a reason for hiding this comment

XhmikosR commented Jan 10, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

XhmikosR Jan 10, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ehmicky Jan 10, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ehmicky commented Jan 10, 2022

XhmikosR commented Jan 10, 2022 via email

ehmicky commented Jan 12, 2022

XhmikosR commented Jan 12, 2022

XhmikosR commented Jan 12, 2022

ehmicky commented Jan 12, 2022 • edited Loading

XhmikosR commented Jan 12, 2022

XhmikosR commented Jan 8, 2022 •

edited

Loading

XhmikosR Jan 10, 2022 •

edited

Loading

XhmikosR commented Jan 10, 2022 •

edited

Loading

XhmikosR Jan 10, 2022 •

edited

Loading

ehmicky Jan 10, 2022 •

edited

Loading

ehmicky commented Jan 12, 2022 •

edited

Loading