chore: remove prepack
and postpack
npm scripts
#4049
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4041 (comment)
prepack
andpostpack
do not seem to be used anymore. I believe those might have been remnants from OCLIF.npm publish
already prunes devDependencies before bundling, so those scripts seem to be noop. I tried to runnpm pack --dry
and it seemed to create the same bundle with or without those scripts.Those npm scripts are a problem because
prepack
is run beforeprepare
.prepare
runshusky
, which is a devDependency. Howeverhusky
is then missing due toprepack
pruning it. This prevents us from runningnpm publish
, and making new releases of Netlify CLI.After merging this, we should be careful when releasing and do some manual testing to ensure this does not break anything.
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.