chore(tests): remove util.promisify

[XhmikosR]

🎉 Thanks for submitting a pull request! 🎉

Summary

Fixes #<replace_with_issue_number>

---

For us to review and ship your PR efficiently, please perform the following steps:

• Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
• Read the contribution guidelines 📖. This ensures your code follows our style guide and
  passes our tests.
• Update or add tests (if any source code was changed or added) 🧪
• Update or add documentation (if features were changed or added) 📝
• Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

[XhmikosR]

Unsure how to make tests run to verify the change is OK... it seems this fails in test:affected

[lukasholzer]

Thank you very much for finding those old legacy parts in our codebase and fixing them! 💪

🚀

[XhmikosR]

NP, glad I could help :)

BTW can you confirm this is fine? CI cannot run due to an issue with the affected test files.

[lukasholzer]

Have you tried running the test locally?

npx ava tests/command.deploy.test.js

✖ No tests found in tests/command.deploy.test.js

Seems like an ava issue not an affected running because it detects the right suite. This error is comming from the testrunner itself

[XhmikosR]

Yeah, it has to do with the affected files script, I believe. So, running the whole suite should be enough, but I can't run it on my machine because ava cripples my dev VM :/

[lukasholzer]

mhmm locally it works like a charm:

[erezrokah]

Failures are related to

cli/.github/workflows/main.yml

Line 69 in 8c73e84

NETLIFY_TEST_DISABLE_LIVE:

.

The deploy tests hit a live API, so we use a Netlify API token in CI.
However, that token is not available to forked pull requests hence we don't run those for forked PRs, causing this failure.

See

cli/tests/command.deploy.test.js

Line 45 in 8c73e84

if (process.env.NETLIFY_TEST_DISABLE_LIVE !== 'true') {

.

I think I'll add a simple always passing test to workaround this issue.