Wrongfully modifies .gitignore #506
Comments
|
Thanks for the report. Looks like we are looking for
|
|
Yeah, I guess you should use a regex there. |
|
i would also prefer to be asked before it edits any existing file tbh |
|
The Adding Closing this for now. |
|
That's just wrong. You are assuming everyone has sub projects. That's not
how git ignores work. And I'd rather be strict with my ignores.
…On Mon, Sep 16, 2019, 21:33 David Wells ***@***.***> wrote:
/.netlify/ will only ignore root .netlify folder.
.netlify will ignore it in parent & in children.
The .netlify folder shouldn't ever be committed into git history as it
could contain sensitive information.
Adding .netlify even if /.netlify/ exists, is the intended behavior
Closing this for now.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#506?email_source=notifications&email_token=AACVLNIIMCARXI4K3DCXNPLQJ7GQDA5CNFSM4ITHHGQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD62C2VI#issuecomment-531901781>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AACVLNIXTPB5JIUXTA7PELDQJ7GQDANCNFSM4ITHHGQA>
.
|
|
And also, why on earth would a tool modify a file that doesn't belong to it
in the first place? That's just nasty.
…On Mon, Sep 16, 2019, 21:35 XhmikosR ***@***.***> wrote:
That's just wrong. You are assuming everyone has sub projects. That's not
how git ignores work. And I'd rather be strict with my ignores.
On Mon, Sep 16, 2019, 21:33 David Wells ***@***.***> wrote:
> /.netlify/ will only ignore root .netlify folder.
>
> .netlify will ignore it in parent & in children.
>
> The .netlify folder shouldn't ever be committed into git history as it
> could contain sensitive information.
>
> Adding .netlify even if /.netlify/ exists, is the intended behavior
>
> Closing this for now.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#506?email_source=notifications&email_token=AACVLNIIMCARXI4K3DCXNPLQJ7GQDA5CNFSM4ITHHGQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD62C2VI#issuecomment-531901781>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AACVLNIXTPB5JIUXTA7PELDQJ7GQDANCNFSM4ITHHGQA>
> .
>
|
|
I hear you @XhmikosR. We need to protect users who might not understand all the intricacies of how This only runs when |
|
I have literally hundreds of projects I don't have on netlify and I just
want to upload quick previews.
This behavior is very annoying and netlify shouldn't even try to make this
change.
So, either tweak the code to work with a regex or drop this IMO.
…On Mon, Sep 16, 2019, 22:18 David Wells ***@***.***> wrote:
I hear you @XhmikosR <https://github.com/XhmikosR>.
We need to protect users who might not understand all the intricacies of
how gitignore patterns work and stop them from committing files that
could contain sensitive information.
This only runs when netlify init and netlify link are executed. Typically
this would happen once per project. You can remove the additional
.gitignore line and everything should be okay.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#506?email_source=notifications&email_token=AACVLNIFBON777EUGQEZZ63QJ7LZPA5CNFSM4ITHHGQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD62HDVQ#issuecomment-531919318>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AACVLNPPBQSNHD3TBBVWQFDQJ7LZPANCNFSM4ITHHGQA>
.
|
|
You guys should seriously reconsider this. I can't be the only one. Just don't modify files that don't belong to you. |
I already have this in my .gitignore file
yet when I link the site the first time, netlify-cli modifies my .gitignore and adds this:
It shouldn't modify .gitignore in this case.
Using
netlify-cli/2.13.1 win32-x64 node-v12.9.1The text was updated successfully, but these errors were encountered: