chore(deps): update dependency @netlify/eslint-config-node to ^4.1.0 (#…

…4009)

* chore(deps): update dependency @netlify/eslint-config-node to ^4.1.0

* fix: fix linting errors

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: ehmicky <ehmicky@gmail.com>

package.json

@@ -186,7 +186,7 @@
     "@babel/preset-react": "^7.12.13",
     "@commitlint/cli": "^16.0.0",
     "@commitlint/config-conventional": "^16.0.0",
-    "@netlify/eslint-config-node": "^4.0.8",
+    "@netlify/eslint-config-node": "^4.1.0",
     "ava": "^3.15.0",
     "c8": "^7.11.0",
     "eslint-plugin-sort-destructure-keys": "^1.3.5",

src/commands/functions/functions-create.js

@@ -164,7 +164,7 @@ const pickTemplate = async function ({ language: languageFromFlag }) {
 
   try {
     templatesForLanguage = formatRegistryArrayForInquirer(language)
-  } catch (_) {
+  } catch {
     throw error(`Invalid language: ${language}`)
   }
 

src/commands/unlink/unlink.js

@@ -20,7 +20,7 @@ const unlink = async (options, command) => {
   try {
     // @ts-ignore types from API are wrong they cannot recognize `getSite` of API
     siteData = await command.netlify.api.getSite({ siteId })
-  } catch (error) {
+  } catch {
     // ignore errors if we can't get the site
   }
 

src/functions-templates/javascript/hasura-event-triggered/{{name}}.js

@@ -20,7 +20,7 @@ const handler = async (event) => {
   let request
   try {
     request = JSON.parse(event.body)
-  } catch (error) {
+  } catch {
     return { statusCode: 400, body: 'c annot parse hasura event' }
   }
 

src/functions-templates/javascript/set-cookie/{{name}}.js

@@ -1,7 +1,7 @@
 const cookie = require('cookie')
 
 // 14 days
-const COOKIE_MAX_AGE = 12096e5
+const COOKIE_MAX_AGE = 12_096e5
 
 const handler = async () => {
   const myCookie = cookie.serialize('my_cookie', 'lolHi', {

src/lib/functions/runtimes/go/index.js

@@ -62,7 +62,7 @@ const invokeFunction = async ({ context, event, func, timeout }) => {
       headers,
       statusCode,
     }
-  } catch (error) {
+  } catch {
     return {
       statusCode: 500,
     }

src/lib/functions/runtimes/js/builders/zisi.js

@@ -72,7 +72,7 @@ const getTargetDirectory = async ({ errorExit }) => {
 
   try {
     await mkdir(targetDirectory, { recursive: true })
-  } catch (error) {
+  } catch {
     errorExit(`${NETLIFYDEVERR} Could not create directory: ${targetDirectory}`)
   }
 

src/lib/functions/runtimes/rust/index.js

@@ -61,7 +61,7 @@ const invokeFunction = async ({ context, event, func, timeout }) => {
       headers,
       statusCode,
     }
-  } catch (error) {
+  } catch {
     return {
       statusCode: 500,
     }

src/utils/deploy/hash-fns.js

@@ -42,7 +42,7 @@ const getFunctionZips = async ({
       })
 
       return functions
-    } catch (error) {
+    } catch {
       statusCb({
         type: 'functions-manifest',
         msg: 'Ignored invalid or expired functions cache',

src/utils/deploy/util.js

@@ -95,9 +95,7 @@ const waitForDeploy = async (api, deployId, siteId, timeout) => {
 // Transform the fileShaMap and fnShaMap into a generic shaMap that file-uploader.js can use
 const getUploadList = (required, shaMap) => {
   if (!required || !shaMap) return []
-  // TODO: use `Array.flatMap()` instead once we remove support for Node <11.0.0
-  // eslint-disable-next-line unicorn/prefer-spread
-  return [].concat(...required.map((sha) => shaMap[sha]))
+  return required.flatMap((sha) => shaMap[sha])
 }
 
 module.exports = {

src/utils/detect-server-settings.js

@@ -346,9 +346,7 @@ const formatSettingsArrForInquirer = function (frameworks) {
       short: `${framework.name}-${command}`,
     })),
   )
-  // Replace by .flatMap() when Node.js support >= 11.0.0
-  // eslint-disable-next-line unicorn/prefer-spread
-  return [].concat(...formattedArr)
+  return formattedArr.flat()
 }
 
 module.exports = {

src/utils/functions/edge-handlers.js

@@ -18,7 +18,7 @@ const validateEdgeHandlerFolder = async ({ site }) => {
       error(`Edge Handlers folder ${EDGE_HANDLERS_FOLDER} must be a path to a directory`)
     }
     return resolvedFolder
-  } catch (error_) {
+  } catch {
     // ignore errors at the moment
     // TODO: report error if 'edge_handlers' config exists after
     // https://github.com/netlify/build/pull/1829 is published

src/utils/gitignore.js

@@ -29,7 +29,7 @@ const ensureNetlifyIgnore = async function (dir) {
   try {
     gitIgnoreContents = await readFile(gitIgnorePath, 'utf8')
     ignorePatterns = parseIgnore.parse(gitIgnoreContents)
-  } catch (error) {
+  } catch {
     // ignore
   }
   /* Not ignoring .netlify folder. Add to .gitignore */

src/utils/lm/requirements.js

@@ -7,7 +7,7 @@ const checkLFSFilters = async function () {
   try {
     const { stdout } = await execa('git', ['config', '--get-regexp', 'filter.lfs'])
     return stdout.length !== 0
-  } catch (error) {
+  } catch {
     return false
   }
 }
@@ -16,7 +16,7 @@ const getHelperVersion = async function () {
   try {
     const { stdout } = await execa('git-credential-netlify', ['version'])
     return stdout
-  } catch (error) {
+  } catch {
     throw new Error(`Check that Netlify's Git Credential helper is installed and updated to the latest version`)
   }
 }
@@ -36,7 +36,7 @@ const checkGitVersion = async function () {
   try {
     const { stdout } = await execa('git', ['--version'])
     return stdout.split(' ').pop()
-  } catch (error) {
+  } catch {
     throw new Error('Check that Git is installed in your system')
   }
 }
@@ -45,7 +45,7 @@ const getLFSVersion = async function () {
   try {
     const { stdout } = await execa('git-lfs', ['version'])
     return stdout
-  } catch (error) {
+  } catch {
     throw new Error('Check that Git LFS is installed in your system')
   }
 }

src/utils/parse-raw-flags.js

@@ -38,10 +38,10 @@ const aggressiveJSONParse = function (value) {
   let parsed
   try {
     parsed = JSON.parse(value)
-  } catch (error) {
+  } catch {
     try {
       parsed = JSON.parse(`"${value}"`)
-    } catch (error_) {
+    } catch {
       parsed = value
     }
   }

src/utils/state-config.js

@@ -29,7 +29,7 @@ class StateConfig {
 
   get all() {
     try {
-      return JSON.parse(fs.readFileSync(this.path, 'utf8'))
+      return JSON.parse(fs.readFileSync(this.path))
     } catch (error) {
       // Don't create if it doesn't exist
       if (error.code === 'ENOENT' || error.code === 'ENOTDIR') {

src/utils/telemetry/request.js

@@ -28,7 +28,7 @@ const makeRequest = async function () {
       body: JSON.stringify(options.data),
     })
     process.exit()
-  } catch (error) {
+  } catch {
     process.exit(1)
   }
 }

tests/command.dev.test.js

@@ -31,7 +31,7 @@ const testMatrix = [
 
 const testName = (title, args) => (args.length <= 0 ? title : `${title} - ${args.join(' ')}`)
 
-const JWT_EXPIRY = 1893456000
+const JWT_EXPIRY = 1_893_456_000
 const getToken = ({ jwtRolePath = 'app_metadata.authorization.roles', jwtSecret = 'secret', roles }) => {
   const payload = {
     exp: JWT_EXPIRY,

tests/command.functions.test.js

@@ -444,7 +444,7 @@ test('throws an error when the --language flag contains an unsupported value', a
 })
 
 const DEFAULT_PORT = 9999
-const SERVE_TIMEOUT = 180000
+const SERVE_TIMEOUT = 180_000
 
 const withFunctionsServer = async ({ builder, args = [], port = DEFAULT_PORT }, testHandler) => {
   let ps

tests/serving-functions.test.js

@@ -13,7 +13,7 @@ const testMatrix = [{ args: [] }, { args: ['esbuild'] }]
 const testName = (title, args) => (args.length <= 0 ? title : `${title} - ${args.join(' ')}`)
 
 const WAIT_INTERVAL = 1800
-const WAIT_TIMEOUT = 30000
+const WAIT_TIMEOUT = 30_000
 const WAIT_WRITE = 3000
 
 const gotCatch404 = async (url, options) => {