feat: emit system log when plugin has failed to load #5679
Conversation
|
This pull request adds or modifies JavaScript ( |
| t.is(systemLog.trim(), 'An error message thrown by Node.js') | ||
| } | ||
|
|
||
| t.snapshot(normalizeOutput(output)) |
There was a problem hiding this comment.
Could we replace the snapshot with a more precise assertion?
There was a problem hiding this comment.
The snapshot is just an accessory thing to ensure we're not throwing an unexpected error somewhere else. The main assertion is ensuring the stuff we pushed to stderr is piped to system logs:
build/packages/build/tests/plugins/tests.js
Line 364 in 59fe711
There was a problem hiding this comment.
If it's about asserting there's no error, maybe it's better to check something like build success? We're always complaining about the snapshot tests so much, so I think we shouldn't add them unnecessarily.
packages/build/src/plugins/load.js
Outdated
| const bufferedStdErr = [] | ||
|
|
||
| if (featureFlags.netlify_build_plugin_system_log && childProcess.stderr) { | ||
| childProcess.stderr.on('data', (data) => { |
There was a problem hiding this comment.
should we unregister this after we're done initialising?
There was a problem hiding this comment.
Good point. Done in a0b4327.
Summary
Right now we don't have any visibility over errors that occur when loading a plugin. This PR tries to address that by emitting system logs for any failures that happen during the plugin loading stage.