fix: for angular v17, detect publish directory from angular.json
#5373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ooops, looked at the problem the wrong way. This will never work. Sad! |
|
a322cfe contains an alternative fix! |
angular.json
julienp
approved these changes
Nov 9, 2023
| const angularJson = await this.project.fs.gracefullyReadFile('angular.json') | ||
| if (angularJson) { | ||
| const { projects, defaultProject } = JSON.parse(angularJson) | ||
| const project = projects[defaultProject ?? Object.keys(projects)[0]] |
There was a problem hiding this comment.
I guess this might go slightly wrong if there's more than one project?
There was a problem hiding this comment.
Totally! Maybe we should add a warning in case there's multiple projects.
minivan
approved these changes
Nov 9, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Angular v17, the publish directory changes based on contents of
angular.json. It's hard to know this from build-info, but thankfully the build plugin deals with all of that! This PR updates the publish directory to"", which gives precedence to the value that's defined by the build plugin.